search

FasterXML / jackson-module-jsonSchema

Module for generating JSON Schema (v3) definitions from POJOs
370 stars 136 forks source link

support json schema generation for @JsonUnwrapped (#20) #61

Closed ciderale closed 9 years ago

ciderale commented 9 years ago

This pull request is in relation to issue #20 and another pull request in the jackson databind repository. This change here is rather an improve tests, while the actual fix is in the jackson-databind repository.

cowtowncoder commented 9 years ago

Sounds good to me; thank you for contribution!

One thing that I do need before merging is the Contributor License Agreement (CLA), from

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

which we need for legal reasons. We only need to get it once and it will work for all contributions across projects, versions etc. If you could print it out, fill, scan and email to info at fasterxml dot com, that would be great. I can then merge the unit test, review other contributions and get it all done.

ciderale commented 9 years ago

Cool, that's great. I just sent you the CLA.