search

FasterXML / jackson-module-jsonSchema

Module for generating JSON Schema (v3) definitions from POJOs
371 stars 135 forks source link

Default visitor context generates invalid URNs #87

Open evshi opened 9 years ago

evshi commented 9 years ago

VisitorContext uses ResolvedType.toCanonical() to create the URN. Problem is implementations of toCanonical in Jackson core types use '<' and '>' to denote type params(e.g. SimpleType). These two characters are excluded from the RFC for URNs: https://www.ietf.org/rfc/rfc2141.txt. Even though you can override the URN generation, I think the default behavior should not generate invalid URNs.

cowtowncoder commented 8 years ago

A unit test would help here, outlining expected handling, current problem.