search

FasterXML / jackson-module-kotlin

Module that adds support for serialization/deserialization of Kotlin (http://kotlinlang.org) classes and data classes.
Apache License 2.0
1.11k stars 175 forks source link

Move to `Github145.testPerson7()` failing test #802

Closed JooHyukKim closed 1 month ago

JooHyukKim commented 1 month ago

Covers #801.

Refer to https://github.com/FasterXML/jackson-module-kotlin/pull/375

cowtowncoder commented 1 month ago

I think we should get this merged.

JooHyukKim commented 1 month ago

I think we should get this merged.

Maybe @dinomite could help?

cowtowncoder commented 1 month ago

@JooHyukKim Ah. I forgot that you probably do not yet have access to merge this. I do, will merge.

cowtowncoder commented 1 month ago

Merged to 2.18, up to master; all tests now pass (except ones under failing/)

k163377 commented 1 month ago

@JooHyukKim @cowtowncoder This test seems to fail locally for me.

By the way, can this test be removed? Since it appears to be deserializing ignoring JsonCreator, I suspect that this test was successful due to some bug.

Therefore, I feel that this test should be removed.

cowtowncoder commented 1 month ago

@k163377 Ultimately you are the module owner so I think your judgment is best here. FWTW I think you are right about test being broken so yeah, let's just remove it.

k163377 commented 1 month ago

Removed https://github.com/FasterXML/jackson-module-kotlin/pull/804