search

FasterXML / jackson-modules-base

Uber-project for foundational modules of Jackson that build directly on core components but nothing else; not including data format or datatype modules
Apache License 2.0
166 stars 77 forks source link

Build from `master` fails due to Moditect plug-in `add-module-info`: "File jackson-module-afterburner-3.0.0-SNAPSHOT.jar is already modular " #214

Open cowtowncoder opened 1 year ago

cowtowncoder commented 1 year ago

So, cloning repository and doing

./mvnw clean install

fails with something like:

[ERROR] Failed to execute goal org.moditect:moditect-maven-plugin:1.0.0.Final:add-module-info (add-module-infos) on project jackson-module-mrbean: File jackson-module-mrbean-3.0.0-SNAPSHOT.jar is already modular -> [Help 1]

with Afterburner module (afterburner/). Same is true for Mr Bean (mrbean/)

This is not happening with 2.16 build for whatever reason.

cowtowncoder commented 1 year ago

@gunnarmorling I was wondering if you had any idea what might be causing this failure? Unfortunately I do not know exact point when this broke, and cannot see specific differences between afterburner/pom.xml on master (jackson 3.0.0-SNAPSHOT) and 2.16. But maybe this sounds similar to a well-known problem.

I do think it is likely related to shading. One diff between 2.16 and 3.0 is that former uses Asm for Afterburner, latter byte-buddy.

cowtowncoder commented 1 year ago

Interesting: for some reason, Moditect plugin (https://mvnrepository.com/artifact/org.moditect/moditect-maven-plugin) version 1.0.0.RC1 still worked but RC2, RC3 and FINAL trigger this failure.

cowtowncoder commented 1 year ago

Downgraded Moditect plug-in in master for now (pluginManagement version override on main-level pom.xml).