Re-apply #235 but now with 2.18 target (not sure what happened earlier)

FasterXML / jackson-modules-base

Uber-project for foundational modules of Jackson that build directly on core components but nothing else; not including data format or datatype modules

Apache License 2.0

166 stars 77 forks source link

Re-apply #235 but now with 2.18 target (not sure what happened earlier) #244

Closed cowtowncoder closed 3 months ago

cowtowncoder commented 3 months ago

@JDUNNIN Ok, merged again. Thank you for the PR!

JDUNNIN commented 3 months ago

@cowtowncoder thank you for this! I assume I got something wrong with my other PR getting up to date with 2.18 but also don't understand how it went elsewhere even though the base was 2.18?!

cowtowncoder commented 3 months ago

@JDUNNIN right. I do know that trying to change base of PR from higher (like 2.18) to lower (like 2.16) typically won't work like I want to (trying to merge 2.16..2.18 changes like here). But it should not occur here, plus target was clearly indicated as 2.18.

Oh well, no harm, it all worked out.