search

FasterXML / jackson-modules-java8

Set of support modules for Java 8 datatypes (Optionals, date/time) and features (parameter names)
Apache License 2.0
401 stars 117 forks source link

`LocalTime` should generate "time" schema instead of "date-time" #105

Closed jaisonpjohn closed 5 years ago

jaisonpjohn commented 5 years ago

When I am generating Swagger spec for a LocalTime Java Object I wanted to get "format" : "time" instead of "format" : "date-time". otherwise it was tripping off a codegen-from-swagger on consumer side.

I have submitted a PR for the same https://github.com/FasterXML/jackson-modules-java8/pull/104

jaisonpjohn commented 5 years ago

@cowtowncoder When you get a chance, could you please take a look. Thanks for your time

cowtowncoder commented 5 years ago

@jaisonpjohn ah sorry for skipping this. Will add to my (somewhat long, arguably... :) ) W-I-P list at https://github.com/FasterXML/jackson-future-ideas/wiki/Jackson-Work-in-Progress

jaisonpjohn commented 5 years ago

@cowtowncoder No worries, Thank you.

cowtowncoder commented 5 years ago

@jaisonpjohn Finally found time to finish this: I ended up doing manual merge to get this in 2.10, and added some baseline unit testing (just for this and couple of other types). Thank you again for submitting this, it'll get in 2.10.0.