search

FasterXML / jackson-modules-java8

Set of support modules for Java 8 datatypes (Optionals, date/time) and features (parameter names)
Apache License 2.0
399 stars 116 forks source link

Serialization : adjust the TimeZone of dates if WRITE_DATES_WITH_CONTEXT_TIME_ZONE is specified #222

Closed vmeunier closed 3 years ago

vmeunier commented 3 years ago

221

vmeunier commented 3 years ago

@kupci @cowtowncoder

Tell me if you think I should add more tests, or if anything is wrong at all :)

cowtowncoder commented 3 years ago

Ok looks good; use of formatter is fine for now as per my comment. So this is good to merge wrt changes.

But one thing I should have asked earlier but I think I missed earlier: CLA. If I haven't yet asked and gotten one (I don't think I have but just in case), it's this 1-page doc:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and is usually easiest to print, fill & sign, scan/photo, email to info at fasterxml dot com. Once I receive it I can proceed with merging. This is only needed once and works for all future contributions.

Looking forward to merging this improvement!

vmeunier commented 3 years ago

@cowtowncoder I have sent you the signed PDF