FasterXML / jackson-modules-java8

Set of support modules for Java 8 datatypes (Optionals, date/time) and features (parameter names)
Apache License 2.0
399 stars 116 forks source link

Change `LocalDateTimeSerializer` constructor protected from private #230

Closed trydofor closed 2 years ago

trydofor commented 2 years ago

replace constructor form private as protected as well as LocalDateSerializer's

https://github.com/FasterXML/jackson-modules-java8/blob/160a8bff02d1d8dc63b06a0f6b7fa4931390d010/datetime/src/main/java/com/fasterxml/jackson/datatype/jsr310/ser/LocalDateTimeSerializer.java?_pjax=%23repo-content-pjax-container#L48

    public LocalDateTimeSerializer(DateTimeFormatter f) {
        super(LocalDateTime.class, f);
    }
  // this constructor 
    private LocalDateTimeSerializer(LocalDateTimeSerializer base, DateTimeFormatter dtf,
            Boolean useTimestamp, Boolean useNanoseconds) {
        super(base, dtf, useTimestamp, useNanoseconds, null);
    }

    @Override
    protected JSR310FormattedSerializerBase<LocalDateTime> withFormat(DateTimeFormatter f,
            Boolean useTimestamp, JsonFormat.Shape shape) {
        return new LocalDateTimeSerializer(this, f, useTimestamp, _useNanoseconds);
    }
cowtowncoder commented 2 years ago

I somehow missed this. Will do for 2.14.