`LocalDateDeserializer` should consider coercionConfig settings

FasterXML / jackson-modules-java8

Set of support modules for Java 8 datatypes (Optionals, date/time) and features (parameter names)

Apache License 2.0

399 stars 116 forks source link

`LocalDateDeserializer` should consider coercionConfig settings #240

Closed maciekdeb closed 2 years ago

maciekdeb commented 2 years ago

Currently LocalDateDeserializer does not take into account the following configuration: setCoercion(CoercionInputShape.Integer, CoercionAction.Fail);

cowtowncoder commented 2 years ago

Looks good to me. Thank @maciekdeb !

Only one more thing I need before merging: if you have not sent a CLA before (I saw one with similar name but not bound to this github handle?), I'd need one from here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual way is to print it, fill & sign, scan/photo, email to info at fasterxml dot com. Once I have CLA I can merge this for inclusion in 2.14.0!

Thank you once again for the contribution!

maciekdeb commented 2 years ago

Thanks @kupci & @cowtowncoder.

I've just sent the CLA to this email address.

I guess other date classes also misses it, when I have more time I can review them, I changed only LocalDate for now as this was the one I stumbled upon.

cowtowncoder commented 2 years ago

@maciekdeb Thank you again! Yes, I think all others could and should be retrofitted too -- that would be valuable contribution. Same also goes for jackson-datatype-joda as well.