search

FasterXML / jackson-modules-java8

Set of support modules for Java 8 datatypes (Optionals, date/time) and features (parameter names)
Apache License 2.0
398 stars 116 forks source link

#286: Get the pre 2.16 constructor of InstantDeserializer back #287

Closed haraldk closed 9 months ago

haraldk commented 9 months ago

Fixes #286

I just added the old constructor back, delegating to the new one with defaults as suggested. You might have some input on the deprecation message.

I didn't add any tests, let me know if that's needed (not really sure what to test in that case..?).

The PR is against 2.17, not sure if it should be against 2.16?

cowtowncoder commented 9 months ago

Ok thank you! So,

  1. No need for tests, addition is fine (feel bit ambivalent on this one, wrt testing... could be convinced about need for test I guess)
  2. Yes, needs to be for 2.16 if and when this is to be included in 2.16.1; 2.17 branch is for 2.17.0 which will take months to release. Unfortunately it may be necessary to create new PR since Github UI doesn't have a good way to re-base (AFAIK -- although would be happy to be proven wrong here!).
cowtowncoder commented 9 months ago

Recreated as #290 just to avoid extra hassle here; will be merging once CI passes.

Thank you @haraldk for reporting this, submitting PR!