search

FasterXML / java-classmate

Library for introspecting generic type information of types, member/static methods, fields. Especially useful for POJO/Bean introspection.
http://fasterxml.com
Apache License 2.0
258 stars 42 forks source link

Missing synchronization on `ResolvedObjectType#getConstructors` #43

Closed pkwarren closed 6 years ago

pkwarren commented 6 years ago

It appears from looking at the code that the ResolvedType#getConstructors method is missing a synchronized keyword. The other methods that behave similarly in the class (getMemberFields, getStaticFields, getMemberMethods) have the keyword specified.

https://github.com/FasterXML/java-classmate/blob/0427b5fc499ff2b1d5796f545528eb4e02473b49/src/main/java/com/fasterxml/classmate/types/ResolvedObjectType.java#L233

cowtowncoder commented 6 years ago

Thank you for reporting this. I'll have to check to see if there is logic to this, but I assume you are right.

cowtowncoder commented 6 years ago

Added synchronized, will be in 1.4.1.

pkwarren commented 6 years ago

Thanks for the quick turnaround @cowtowncoder!