Simplify code by not calling `Set.contains()` before `add()`

FasterXML / java-classmate

Library for introspecting generic type information of types, member/static methods, fields. Especially useful for POJO/Bean introspection.

http://fasterxml.com

Apache License 2.0

258 stars 42 forks source link

Simplify code by not calling `Set.contains()` before `add()` #83

Closed mebigfatguy closed 8 months ago

mebigfatguy commented 8 months ago

No need to do contains before add, just does two set traversals instead of one.

cowtowncoder commented 8 months ago

Makes sense: my only (theoretical) concern would be with LRU-style LinkedHashSet (where ordering could change), but I'm pretty sure that isn't relevant here.

Thanks!