FasterXML / woodstox

The gold standard Stax XML API implementation. Now at Github.
Apache License 2.0
225 stars 81 forks source link

Changes in support of Issue #175 #181

Closed Orbisman closed 2 months ago

Orbisman commented 11 months ago

Pull request for Issue #175..

Dependent on Issue #7 on the MSV project being approved and code accepted.

New JUnit w/supporting files included.

Note: pom file change should not be included, my mistake.

cowtowncoder commented 11 months ago

Minor update to pom.xml wrt msv-core dependency; updated to latest non-snapshot in master.

Orbisman commented 10 months ago

That works, just wanted to finish up the code and get it uploaded before I forgot..

On Tue, Nov 7, 2023 at 8:45 PM Tatu Saloranta @.***> wrote:

@.**** commented on this pull request.

In pom.xml https://github.com/FasterXML/woodstox/pull/181#discussion_r1385854165:

   <!-- Woodstox 5.0 is 1.6+ -->
  • 1.6
  • 1.6
  • 1.8

Will then need to go in after #134 https://github.com/FasterXML/woodstox/issues/134 is done (which itself is after 6.6.0 release). Probably not a problem as MSV-core change may take a while.

— Reply to this email directly, view it on GitHub https://github.com/FasterXML/woodstox/pull/181#pullrequestreview-1719168759, or unsubscribe https://github.com/notifications/unsubscribe-auth/BA7WS6W6JSGTXLZU65KTOBLYDLP2NAVCNFSM6AAAAAA7B7XAZCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMJZGE3DQNZVHE . You are receiving this because you authored the thread.Message ID: @.***>

cowtowncoder commented 5 months ago

@Orbisman Is this still active? While the referenced issue in MSV was closed, there doesn't appear to be a new build available so I don't think this can be completed... but maybe at least could trim down changes to pom.xml?

Orbisman commented 2 months ago

Sorry for the delayed response, yes, remove the POM changes that was in error...

Orbisman commented 2 months ago

Going to resubmit pull request without pom