Try resolve #193: exclude refs to shaded modules

FasterXML / woodstox

The gold standard Stax XML API implementation. Now at Github.

Apache License 2.0

220 stars 81 forks source link

Try resolve #193: exclude refs to shaded modules #198

Closed cowtowncoder closed 4 months ago

cowtowncoder commented 4 months ago

Remove provides statements from module definition; hoping this resolves #193.

cowtowncoder commented 4 months ago

@pjfanning So basically, would this help avoid the issue?

pjfanning commented 4 months ago

seems to fix the broken test runs in POI - I'm running som extra tests - I'll get back when they complete

the JPM stuff is really hard to get right and harder to test

pjfanning commented 4 months ago

the test run completed - seems like this might help - I hope it doesn't break something else - but so hard to know

cowtowncoder commented 4 months ago

@pjfanning Ok thanks! I think I should just go ahead and merge this, push a release. It's the only accumulated 6.6 change and if module stuff is not working it can't break worse (.. I hope).