search

FasterXML / woodstox

The gold standard Stax XML API implementation. Now at Github.
Apache License 2.0
220 stars 81 forks source link

WstxEventFactory: Ensure events' immutable non-null location #205

Closed stanio closed 2 months ago

stanio commented 3 months ago

Addresses #204:

The latter is a secondary issue noted in the original report.

stanio commented 2 months ago

@cowtowncoder, would you review this, when you get the time?

cowtowncoder commented 2 months ago

Hi @stanio! Thank you for contributing this & apologies for slow follow-up.

I am traveling for work this week but will try to review this when I get home.

cowtowncoder commented 2 months ago

@stanio I am now reviewing this and it looks good so far so I think there won't be issues.

But one last process thing before I can merge the fix is to get a CLA from

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

(unless you have sent one for Woodstox or Jackson contributions). It's usually easiest to print, fill & sign, scan/photo, email to cla at fasterxml dot com. Once we get it, CLA is good for any and all contributions to FasterXML projects so it's one-time-only thing.

Looking forward to merging this; will now complete the review.

cowtowncoder commented 2 months ago

Ok, so after getting CLA & merging, I think I'll backport this into 6.6 for inclusion in 6.6.3 (should be easy to cherry-pick).

Thank you again for contributing this!

stanio commented 2 months ago

I have sent my CLA earlier today.

cowtowncoder commented 2 months ago

Merged into master for eventual 7.0.0, but also backported into 6.x for 6.7.0