search

Fatal1ty / aiofcm

An efficient Firebase Cloud Messaging Client Library for Python/asyncio
Apache License 2.0
34 stars 19 forks source link

chore: type hinting #16

Closed holyachon closed 1 year ago

holyachon commented 1 year ago

due to https://github.com/Fatal1ty/aiofcm/pull/15#discussion_r1133243587

holyachon commented 1 year ago

I also want to add CI like here. But it will make big diffs, so I will do it after #15, #16 merged.

Fatal1ty commented 1 year ago

There're some conflicts with the new max_connection_attempts argument you added but everything else is good!

holyachon commented 1 year ago

There're some conflicts with the new max_connection_attempts argument you added but everything else is good!

@Fatal1ty Could you please check it again? I have resolved the conflict now.

Fatal1ty commented 1 year ago

@Fatal1ty Could you please check it again? I have resolved the conflict now.

Looks good!

I also want to add CI like here. But it will make big diffs, so I will do it after #15, #16 merged.

Will be ready to make a new release after that 🙏