search

Fatal1ty / mashumaro

Fast and well tested serialization library
Apache License 2.0
758 stars 45 forks source link

Add slots to [Generic]SerializableType #156

Closed mishamsk closed 1 year ago

mishamsk commented 1 year ago

Hey,

Just realized that SerializableType and GenericSerializableType do not define __slots__ (unlike DataClassXXXMixin) which indirectly makes it impossible to create/use slotted custom types.

Very small change, looks pretty benign to me, but valuable.

Fatal1ty commented 1 year ago

Oh, good catch! I didn't even think about it. Thanks you, I'll merge it and update test_slots later on.

mishamsk commented 1 year ago

@Fatal1ty thanks. so far I had to resort to this in my new version ;-)