search

Fatal1ty / mashumaro

Fast and well tested serialization library
Apache License 2.0
774 stars 45 forks source link

Fix errors in readme #171

Closed Gwill closed 10 months ago

Fatal1ty commented 1 year ago

Why did you change it to Chinese? This format is used in Japan: https://en.wikipedia.org/wiki/Date_and_time_notation_in_Japan

Gwill commented 1 year ago

This is a more commonly used format in the Chinese context. https://en.wikipedia.org/wiki/Date_and_time_notation_in_Asia#Date_2

And the 年, 月, 日 are all Chinese characters. 😂

Fatal1ty commented 10 months ago

Japan uses this format, so I don’t see any mistakes here. Also, the purpose of the example in the README is to show the differences between the two date formats without going into linguistic debates. The roots of the origin of the format or characters do not play any role here.