Fatal1ty / mashumaro

Fast and well tested serialization library
Apache License 2.0
774 stars 45 forks source link

Benchmark is not working in master branch #173

Closed meshin-dev closed 1 year ago

meshin-dev commented 1 year ago

Steps to reproduce (as described in readme):

git clone https://github.com/Fatal1ty/mashumaro.git                                                                                                    ─╯
cd mashumaro
python3 -m venv env && source env/bin/activate
pip install -e .
pip install -r requirements-dev.txt
./benchmark/run.sh

Error:

Traceback (most recent call last):
  File "/Users/dmitri/projects/mashumaro/benchmark/libs/mashumaro/load.py", line 2, in <module>
    from benchmark.libs.mashumaro.common import Benchmark
  File "/Users/dmitri/projects/mashumaro/benchmark/libs/mashumaro/common.py", line 50, in <module>
    @dataclass(slots=True)
TypeError: dataclass() got an unexpected keyword argument 'slots'
Fatal1ty commented 1 year ago

@meshin-dev

I guess you’re trying to run them on old Python version. Slots were added in Python 3.10.

Do you have a reason to run benchmarks on Python < 3.10 or we can close this issue?

meshin-dev commented 1 year ago

Yeah, it was on python3.9 Thanks!