Forbid extra option and bubbling up the inner-most exception

mishamsk commented 10 months ago

Hi,

This does two things:

Mostly implements #136 (see below)
Adds a new config option forbid_extra_keys, that, well, checks for extra keys during deserialization and fails with a new exception.

Caveats:

The codecs code is pretty dense, I've tried to understand it without the comments, but do not feel confident enough to apply any changes there => the new features may or may not work for codecs
I dropped the ball on implementing the full path for sequences. I do not think that their going to be any noticeable performance penalty to track current sequence index, but to implement it, the whole unpack_collection must change from an expression generator to a full sub-builder. That's a bit too much for my time constraints;-)

I'd love this to be merged though. I think it adds quite a lot of value already.

Let me know what you think!

pep8speaks commented 10 months ago

Hello @mishamsk! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2023-12-17 16:04:54 UTC

Fatal1ty commented 9 months ago

Hi @mishamsk

Reviewing pull requests with mixed changes can be challenging. As a result, it has taken me some time to respond. Would you kindly consider splitting the pull request into separate parts? I appreciate your work and I'd like to review forbid_extra_keys part first since it looks less destructive. However, I would like to take more time to reflect on the other changes before making a decision. Thank you for your understanding.

mishamsk commented 8 months ago

Yeah, makes sense. Sorry for mixing these. Will get to it eventually, a bit busy now

mishamsk commented 7 months ago

split into #198 & #199 , closing

Fatal1ty / mashumaro

Forbid extra option and bubbling up the inner-most exception #183

Comment last updated at 2023-12-17 16:04:54 UTC