Closed mishamsk closed 7 months ago
Hello @mishamsk! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
Hi @mishamsk
Reviewing pull requests with mixed changes can be challenging. As a result, it has taken me some time to respond. Would you kindly consider splitting the pull request into separate parts? I appreciate your work and I'd like to review forbid_extra_keys
part first since it looks less destructive. However, I would like to take more time to reflect on the other changes before making a decision. Thank you for your understanding.
Yeah, makes sense. Sorry for mixing these. Will get to it eventually, a bit busy now
split into #198 & #199 , closing
Hi,
This does two things:
forbid_extra_keys
, that, well, checks for extra keys during deserialization and fails with a new exception.Caveats:
unpack_collection
must change from an expression generator to a full sub-builder. That's a bit too much for my time constraints;-)I'd love this to be merged though. I think it adds quite a lot of value already.
Let me know what you think!