Closed vovanbo closed 7 months ago
the reason why I didn't use decorator in #180 (which also fixes this issue + adds tests) is because decorators are a bit of magic and less explicit. They may even not work in some cases, e.g. we compile a project depending on mashumaro using Nuitka, which sometimes struggles with overly "magical" stuff.
What I didn't do in my PR is adding a schema test. Maybe it would make sense to merge the test from this PR with the change from mine?
Anyways, we need @Fatal1ty to return from vacation;-)
Anyways, we need @Fatal1ty to return from vacation;-)
I promise to get back to the business this weekend 👀
Is this pull request still required? #182 is fixed now as i see. When new version of mashumaro will be released?
Is this pull request still required? #182 is fixed now as i see.
As @mishamsk pointed out, it'll be worth merging the tests from here, I'll do it after.
When new version of mashumaro will be released?
Right after getting this and #187 done if nothing new comes up :)
The fix for discriminators was easy to implement #189. I believe local types are now fully supported.
Fix #182. Another try to fix this bug with simple decoration of
type_name
method.