Fate-Grand-Automata / FGA

Auto-battle app for F/GO Android
https://fate-grand-automata.github.io
MIT License
1.46k stars 269 forks source link

Script fails after the first run #1057

Closed saiyan11 closed 2 years ago

saiyan11 commented 2 years ago

Preparation

FGO server

JP

FGA build number

1597

Describe the bug

I program the script to run the same quest 3 times in a row. The first time it goes perfectly, but the next ones it skips NPs, doesn't click on skills or selects skills or NPs in a wave in which they shouldn't be activated.

For example: in the second run the script selects all NPs whereas it should only select Koyanskaya's. Here my configuration:

Video

https://youtu.be/yA5RzjvaJFI

Device model

Xiaomi Redmi Note 7

Android version

10

Screen size

1080x2340

RAM

6 GB

reconman commented 2 years ago

After looking closely at your video, I see a few things going wrong:

  1. Servant Details for your own Servants aren't opened correctly. That's because of timing issues.
  2. Skills are executed normally, but NP Spam is broken in the 2nd run.

For the first problem, increase your "Wait before turn" delay in the Fine-Tune settings. The crit star animation playing when Morgan's CE effect is activated is the problem why she isn't detected. I would propose a setting of 2000-2500 ms.

I currently can't think of a way to handle that better. That will maybe also fix the 2nd problem.

saiyan11 commented 2 years ago

I downloaded the last build (1599) and now it works fine. Thanks for your hard work.

reconman commented 2 years ago

I didn't fix anything, you still need to change what I told you to.