Fate-Grand-Automata / FGA

Auto-battle app for F/GO Android
https://fate-grand-automata.github.io
MIT License
1.5k stars 274 forks source link

FGA only works during battle after the NA update, does not auto select support or end battles. #1422

Open ironmaiden0 opened 2 years ago

ironmaiden0 commented 2 years ago

Preparation

FGO server

NA

FGA build number

1856

Describe the bug

The service gets stuck in the support list and does not tap or scroll. Same when ending battles, service gets stuck on the rewards modal and does not tap.

The battle works fine but I have to adjust the Game Area Mode after the update. Everything works fine on my android before, no need to adjust anything.

Tried enabling the "Skip servant face-card checks" but issue still occurs.

Video

Screenshot_20221030_202706_com mathewsachin fategrandautomata debug

Battle Config Screenshot_20221030_211907_com mathewsachin fategrandautomata debug

Tried other support options (e.g. Selection Mode > First) but still does not auto select any.

Video of support list issue here: https://user-images.githubusercontent.com/117018831/198879777-43a6900b-e4bd-4ed9-b75c-8b8bc90ed279.mp4

Video of ending battle here: https://user-images.githubusercontent.com/117018831/198880554-b0aee81e-72a5-4a7c-88e5-ac4e156d1442.mp4

Device model

Huawei Nova 3

Android version

9

Screen size

1560 x 720

RAM

6

reconman commented 2 years ago

Seems like you have enabled custom game area even though you don't have black bars.

ironmaiden0 commented 2 years ago

Seems like you have enabled custom game area even though you don't have black bars.

yea, it was disabled before but after the NA update, the targeted skills do not point to correct servants (e.g. targeting Servant 1 with a skill incorrectly gives it to Servant 2). I had to enable custom game area to make sure the skills point properly.

Issue occurs even before I adjust game area

vybze commented 2 years ago

Do you have skill use confirmation turned off in both fgo and fga?

ironmaiden0 commented 2 years ago

Do you have skill use confirmation turned off in both fgo and fga?

I have it both turned off, fgo and fga

reconman commented 2 years ago

Can you double check and record videos without custom game area?

ironmaiden0 commented 2 years ago

Can you double check and record videos without custom game area?

Yes, both are disabled. I also disabled the custom game area. Here's the support issue still occurring https://user-images.githubusercontent.com/117018831/198882855-2d84c1dc-ae5b-401c-8b7c-c34231f287c4.mp4

Here's the skill not given to proper servant (2nd wave, waver's skill should be to bunyan and not penth) https://youtu.be/TZ8vMrK9KYI

I should say that I've been using FGA for several months now and I only encountered this issue after the NA update.

reconman commented 2 years ago

Duplicate of #943, some UI elements get stretched.

What happens if you disable fullscreen mode and use custom game area for the black bars?

ironmaiden0 commented 2 years ago

Duplicate of #943, some UI elements get stretched.

What happens if you disable fullscreen mode and use custom game area for the black bars?

The offset suggestion by the bot does not seem to work on support list issue, still not selecting any servant.

It works on the battle sequence tho, the skills were applied properly.

reconman commented 2 years ago

Can you post another video of the support list for reference?

ironmaiden0 commented 2 years ago

Can you post another video of the support list for reference?

here it is https://user-images.githubusercontent.com/117018831/198888337-8edfe855-0313-4711-80e5-7d95ea199d46.mp4

reconman commented 2 years ago

Hold on, where did the left black border from the black bar megathread go?

ironmaiden0 commented 2 years ago

Hold on, where did the left black border from the black bar megathread go?

Apologies. I tried with and without the notch.

It seems to always hit the quest information button at the start of the quest when both black bars are enabled.

https://user-images.githubusercontent.com/117018831/198889784-a82c9180-40d8-4a74-b873-f1a7e697cf39.mp4

Moving past that issue, the support and battle issues do not occur when both black bars are enabled. battles start and repeat properly with correct support. https://youtu.be/1-cCxM39HpU

reconman commented 2 years ago

The bottom right rectangles are too far to the right, so that's an indication of the right offset being too low. Did you use 141 pixels offset?

ironmaiden0 commented 2 years ago

The bottom right rectangles are too far to the right, so that's an indication of the right offset being too low. Did you use 141 pixels offset?

I did, Screenshot_20221031_004123_com mathewsachin fategrandautomata debug

reconman commented 2 years ago

I only watched the battle video just now, FGA's rectangles are drawn in incorrect places, but image matching still works.

Could you test what happens if you disable the notch for FGO and FGA and set the left offset to 0?

ironmaiden0 commented 2 years ago

I only watched the battle video just now, FGA's rectangles are drawn in incorrect places, but image matching still works.

Could you test what happens if you disable the notch for FGO and FGA and set the left offset to 0?

The information button is still tapped, and the support selection does not work again (I manually tapped to go to support list on the video) . https://user-images.githubusercontent.com/117018831/198891981-2ca74f1d-f338-499b-b98e-e2ff875035de.mp4

The fights still work but is not repeating https://youtu.be/55jj-rIQpys

reconman commented 2 years ago

Just to double check, your left offset is at 0 and you disabled the notch for FGA? (not in FGA's setting but via your system settings similar to FGO)

ironmaiden0 commented 2 years ago

Just to double check, your left offset is at 0 and you disabled the notch for FGA? (not in FGA's setting but via your system settings similar to FGO)

Yes I did, Screenshot_20221031_014017_com mathewsachin fategrandautomata debug

Screenshot_20221031_014045

reconman commented 2 years ago

Shouldn't it say "Don't show notch"?

ironmaiden0 commented 2 years ago

Shouldn't it say "Don't show notch"?

hiding notch results in the left black bar I video earlier

reconman commented 2 years ago

Then try Show notch for FGO and Don't show notch for FGA.

ironmaiden0 commented 2 years ago

FGO show notch, FGA hide notch > still tapping the info button and not selecting supports Screenshot_20221031_015615

I manually opened support list again here* https://user-images.githubusercontent.com/117018831/198893702-451c00f9-dd58-49da-bc85-53872fce8c95.mp4

ironmaiden0 commented 2 years ago

FGO hide notch, FGA show notch > still taps the info button but selects supports properly

also added right +60 offset when trying this

reconman commented 2 years ago

also added right +60 offset when trying this

But why? The right offset doesn't change, only the left one does depending on the notch settings.

ironmaiden0 commented 2 years ago

also added right +60 offset when trying this

But why? The right offset doesn't change, only the left one does depending on the notch settings.

because the left black bar appeared when hiding notch on FGO. anyway, I also tried without right +60 offset and it taps the quest properly but does not select supports

reconman commented 2 years ago

I'll leave any further testing to you, my comments don't really work when I can't watch in real time what you're doing.

Please use FGA's rectangle as guide for correct/incorrect settings.

How top left of support should look like: image

How bottom right should look like: image Notice how the biggest rectangle is perfectly in the corner.

ironmaiden0 commented 2 years ago

Will do! thanks for the help, I appreciate it.

reconman commented 2 years ago

For better understanding, if there's a black border, the bottom right rectangle looks like this: image