Fate-Grand-Automata / FGA

Auto-battle app for F/GO Android
https://fate-grand-automata.github.io
MIT License
1.37k stars 267 forks source link

Skill confirmation disappeared from more option #1705

Open Andybui1012 opened 7 months ago

Andybui1012 commented 7 months ago

Preparation

FGO server

NA

FGA build number

2265

Describe the bug

I noticed that the app was clicking on the wrong servant and after checking the issue, i realized it is because of the skill confirmation being enable in FGA, but when i looked in more option, i couldn't find it.

Video

image

Device model

Nox

Android version

7

Screen size

No response

RAM

No response

reconman commented 7 months ago

FGA now auto-detects Skill Confirmation because too many messed up the setting. Had about 1 user report per day about an issue related to Skill Confirmation, no matter what I changed regarding the setting.

Did you enable Root for Screenshots according to https://github.com/Fate-Grand-Automata/FGA/wiki/Running-on-Emulators ?

If yes and it still doesn't work, post a video with debug mode.

DAOWAce commented 7 months ago

Not sure if this is what the OP means:

https://github.com/Fate-Grand-Automata/FGA/assets/480587/b50a7771-3548-4454-af4b-193dbdeb9681

I commented in another issue https://github.com/Fate-Grand-Automata/FGA/issues/1328 about something related to it, as they both seemed to happen around the same time.

Note: Specifically in that video it was Emiya's NP change skill that triggered it, but it is not the sole trigger. Using Saber Okita seemed to trigger it almost every run compared to other rented servants it picked (had a video but no debug); would just come back an hour later and find FGA got stuck 40 minutes ago trying to use skills that were already used.

Also separate issue, the script cannot enter battles that popup that "you'll set your squad before the battle" prompt; and there's quite a number of them in every part of the game. Makes the automation part of things, well, quite a problem.

With this Christmas event, there's that pre-battle prompt, and forced usage of a 1 skill servant which seems to completely break FGA almost every single time (if set to spam all; doesn't see there's no skill there, can get stuck like in the video)..

PKX commented 7 months ago

Can confirm skills are now completely broken after this change, it always gets stuck at the same spot: https://imgur.com/zKltn8z

With an old version, it works https://imgur.com/QAYltGQ

reconman commented 7 months ago

@PKX In this case, your battle command contains e for the 1st wave but no target for it.

The previous app version canceled out of it by clicking in the top right while the current app version doesn't handle your incorrect command.

Correct your command and then it should be fixed.

@DAOWAce I think in your case Skill Spam can't handle Emiya's special skill and that's why you're getting stuck.

The only valid case for errors related to Skill Confirmation I saw was when you start the battle, stop the script and then start it again. FGA will see the OK/Cancel dialogue because the skills are on cooldown and will assume that Skill Confirmation is enabled in FGO.

ArthurKun21 commented 6 months ago

@DAOWAce skill spam can't handle special case because it was not coded to handle it. You might get lucky with Space Ishtar though since hers looks a bit similar to the normal target scheme

DAOWAce commented 6 months ago

@ArthurKun21 Yeah, I thought Sishtar had to be manually added back when she got introduced into NA. Not sure if that was the discussion, but remember reading her mentioned in these issues back on release. If it was, then Emiya's update needs the same treatment.

But still, that wasn't really the point of the video, it's just the only one I had with the debug info on. As mentioned, saber Okita (not alter) last event was triggering this extremely frequently, usually in wave 3. I can see if I can find her for rental and cap another video for visuals as to exactly what's going on, but this is an issue other people have reported for a number of years now. A few of them, not all the same cause though:

https://github.com/Fate-Grand-Automata/FGA/issues/248 https://github.com/Fate-Grand-Automata/FGA/issues/468 https://github.com/Fate-Grand-Automata/FGA/issues/1041 https://github.com/Fate-Grand-Automata/FGA/issues/1045 https://github.com/Fate-Grand-Automata/FGA/issues/1295 https://github.com/Fate-Grand-Automata/FGA/issues/1349

I have personally seen a few other issues over the years (not using skills, not using NP, getting stuck on other waves/servant selection, issues with story skip), but they seem to be resolved at this point. The main problem at present really is this obtuse 'getting stuck on servant details'. And the double-tapping thing.

It's also very frequently popping up the text "can't determine blah blah" when selecting cards, but still seems to select the right order. I don't know why; I'd assume all the images are already there from JP which is 2 years ahead of NA. Maybe some text is interfering?

Can confirm that old versions (like really old) did seem to work better in some areas, but they lacked the skill spam function (and probably don't work anymore anyway), and I can't manually setup things for teams as I'm just not that kind of player. Skill spam has been a godsend. I can understand maybe setting up specific automation for farming specific stages without relying on rentals, but for use over the entire game? Just not feasible at all.

@reconman Does FGA have functionality to see skills are on cooldown now? Was reading in older issues it didn't do that, but your comment if I'm understanding it right implies it does detect it now? I thought last time I stopped/started script in battle it tried to use the skills all over again, so I'm not sure.

Anyway, give me a day or two and I'll try to get a new video recorded about the issue.

DAOWAce commented 6 months ago

Got it, and now I think I see what's happening.

https://github.com/Fate-Grand-Automata/FGA/assets/480587/3a583eea-625e-4bee-a305-6499e8eaee23

The detection box is a bit to the left of the skill number, and/or it looks like the OCR is tripping up on that specific icon.

This can be adjusted with the "game area mode", right? I'm not sure how to use the options though.

reconman commented 6 months ago

The only valid case for errors related to Skill Confirmation I saw was when you start the battle, stop the script and then start it again.

And skill spam only compares before/after images, it doesn't check for numbers right now.

FGA always assumes skills can be used when starting the script in battle.

nguyentrong101094 commented 6 months ago

is there a previous release that work? Checked the releases page and the last release was 3 years ago.

DAOWAce commented 6 months ago

The only valid case for errors related to Skill Confirmation

So I should open a new issue with a different title and copy/paste all this information over there, got it.