Fate-Grand-Automata / FGA

Auto-battle app for F/GO Android
https://fate-grand-automata.github.io
MIT License
1.37k stars 267 forks source link

Bring back multiple apple option #1804

Open muscularcandy67 opened 2 months ago

muscularcandy67 commented 2 months ago

Preparation

Describe the feature

Apparently the feature was removed when blue apple was introduced in JP. Since the new blue apple is now on NA too, why don't you bring back the feature to select different types of apple for farming?

reconman commented 2 months ago

I had to remove it because now you have to scroll to select copper apples and this might cause troubles when copper is combined with another apple but there are 0 copper apples left.

muscularcandy67 commented 2 months ago

Even with this PR it's impossible to bring it back?

ArthurKun21 commented 2 months ago

that just selects one apple and go for the maximum amount.

image

muscularcandy67 commented 2 months ago

Doesn't that PR also have a number detection for bronze apple in the first commit? image

ArthurKun21 commented 2 months ago

that just selects one apple and go for the maximum amount.

image

It doesn't detect the per apple, only when you selected an apple like in this image then afterwards can detect the number of apple that gonna be used.

muscularcandy67 commented 2 months ago

Couldn't though the logic be recycled for this use case? With it you could detect if bronze apples are 0 or scale the bronze apple amount based on the number of bronze apple used and go the next selected apple and start counting again how many refills are used for that type of apple

ArthurKun21 commented 2 months ago

If you got time to implement it, why not?

Personally, this is no longer my top priority as I'm still doing other features

muscularcandy67 commented 2 months ago

I'm not saying it's urgent but it would be nice if the feature is brought back now that the apple change is on all servers