Closed sleeping-player closed 3 years ago
Mentioning #753
I assume you know that you can move the play icon right? It works perfectly for me if I put it to the top-left side of the screen. But for some reason for this update in my case, the support list doesn't work properly, it won't auto pick even if I tuned it to select the first support.
I assume you know that you can move the play icon right? It works perfectly for me if I put it to the top-left side of the screen. But for some reason for this update in my case, the support list doesn't work properly, it won't auto pick even if I tuned it to select the first support.
Oh there was that way too. But from what I've heard, the location of the button was decided after careful consideration, so I was originally told that the location was the best and should not be moved if possible.
Yeah, most top left side is going to be a problem too actually, cause that's the reason it doesn't select the supports as the pause button now is blocking an important part.
The update going total full screen really fuck things up. You just need to find a perfect place for the buttons to not block the important part of the screen.
So, going forward, FGA should assume Ignore notch calculation
for JP.
I guess I'll have to show one button at a time. How about we only show the Pause
button when the script is running and once you pause, you get both the buttons to either Resume
or Stop
? That should solve this problem if there are no other changes.
With these changes, I believe no action would be needed on the user's end.
So, going forward, FGA should assume
Ignore notch calculation
for JP.I guess I'll have to show one button at a time. How about we only show the
Pause
button when the script is running and once you pause, you get both the buttons to eitherResume
orStop
? That should solve this problem if there are no other changes. With these changes, I believe no action would be needed on the user's end.
I remember that the solution was suggested before. Perhaps it is the time to implement it.
I remember that the solution was suggested before.
I don't remember that 😆. I might've missed that discussion.
I'll implement it in the compose branch first since the UI part is different from the canary one.
I don't think that the Pause button matters here From what i've seen the whole UI was moved which makes FGA to choose diffrent skills and it has problem with recognizing the places of the buttons.
Ignore Notch Detection is enabled, of course.
@WiktorFGO, this step is important for now. Without it, things would be offset by the notch width.
Can I add on to this issue? The lottery box command can go through the lotto pulls fine, but is unable to reset the box properly. I have alrdy ignored notch calculation, and changing the screen orientation both ways doesn't fix it.
Can you provide a debug mode video of the lottery script not working?
The screen orientation is such that the notch is to the right of the screen
That reset button has shifted a bit to the right. I want to check if it has moved on 16:9 too and also if it is right or center aligned. Can someone get me a screenshot on a 16:9 device?
This is how it looked in 16:9 on last lottery:
Taken from my 16:9 phone. Lottery box reset works on it.
my problem
https://youtu.be/nJzYh1o8dgA
Not the exact same issue, but I believe it is caused by the same update. I am getting an error when on the support select screen:
Unexpected Error: Width must be positive
Time: 00:01
java.lang.Exception: Unexpected Error: Width must be positive
Time: 00:01
at h.a.a.c.a.a.z(AutoBattle.kt:32)
at h.a.b.b.c(EntryPoint.kt:3)
at g0.n.a.run(Thread.kt:1)
Caused by: java.lang.IllegalArgumentException: Width must be positive
at h.a.b.t.
This is on a Samsung Galaxy S8+, tried with ignore notch calculation off and on, I have tried rotating the screen to have the cable end on each side, I have tried moving the play button, and I believe I am on the Canary-1389.
Confirmed scripts will run when in battle and for lottery, only fails and produces error after the initial screen check of the Support Select screen.
Should be fixed with 5e3860c3c3f9ebcbe25bf4954b2559c54d5bdba8
Before opening an issue:
Describe the bug Today there was an update to the FGO JP app, including a resolution extension. The screen display area was expanded to the notch area, and when the notch was placed on the left side of the screen, the FGO command of Servant 1 was placed under the FGA pause button during battle. For this reason, when the FGA executes the "a" command, it presses its own pause button located there, and does not apply a buff to the Servant. If the screen is reversed, the FGA works normally.
It seems that there have been people who have said this before, but this JP update seems to make the problem bigger. First of all, it seems necessary to explain in https://github.com/Fate-Grand-Automata/FGA/wiki/Game-Area-detection to play with the cable facing the left side of the device's rotation direction.
Currently, one device is using compose branch build and the other is using normal canary build, both of which have a notch or something like that, so they were affected by the JP update.
Ignore Notch Detection is enabled, of course.
Screenshots
Video https://youtu.be/ITHcHSxOU1s The script in this video starts with "afgh2".
Device Info (please fill at-least 'Device model'):