search

Fate-Grand-Automata / FGA

Auto-battle app for F/GO Android
https://fate-grand-automata.github.io
MIT License
1.45k stars 267 forks source link

Max-level support skills not being detected #850

Closed minhducsun2002 closed 2 years ago

minhducsun2002 commented 3 years ago

Preparation

FGO server

NA

FGA build number

1485

Describe the bug

Detection of supports' max skills seem to be failing.

Video

https://media.discordapp.net/attachments/755763097788088330/882964834948362250/record.mp4

Device model

Bluestacks Hyper-V 4.280

Android version

7

Screen size

960x540

RAM

No response

MathewSachin commented 3 years ago

Skadi's first skill isn't matching correctly. Maybe not enough similarity on scaling down the new transparent skill 10 image to 540p.

reconman commented 2 years ago

@minhducsun2002 @JusKIdding Can you try this build? https://github.com/Fate-Grand-Automata/FGA/suites/3683687739/artifacts/89738887

JusKIdding commented 2 years ago

@minhducsun2002 @JusKIdding Can you try this build? https://github.com/Fate-Grand-Automata/FGA/suites/3683687739/artifacts/89738887

Hi, tested, the first skill is still not being detected correctly.

JusKIdding commented 2 years ago

Hi, created a new comment to pump up the thread with a recording for evidence.

Build: 1489 - Issue #850 Record

MathewSachin commented 2 years ago

@reconman can you switch to the old skill 10 image just for NA with black background to see if that works.

reconman commented 2 years ago

@JusKIdding It's really weird how we both have 1080p screens, yet your similarity is much lower than mine.

Can you post a screenshot of your support screen? I'm going to test out image detection some time this week. I'm currently a bit busy.

@MathewSachin Not only would the background be set to black, the min similarity would also need to be reduced again for all servers except for JP.

MathewSachin commented 2 years ago

Not only would the background be set to black, the min similarity would also need to be reduced again for all servers except for JP.

Ok. I'll get a build ready in a few minutes for them to test.

MathewSachin commented 2 years ago

@JusKIdding try this one: https://github.com/Fate-Grand-Automata/FGA/suites/3703247669/artifacts/90394086

minhducsun2002 commented 2 years ago

@JusKIdding try this one: https://github.com/Fate-Grand-Automata/FGA/suites/3703247669/artifacts/90394086

This works for me. Recording here. IMG_20210907_230029

JusKIdding commented 2 years ago

@JusKIdding try this one: https://github.com/Fate-Grand-Automata/FGA/suites/3703247669/artifacts/90394086

Yeap it's working as intended. Sorry for late reply.