Fate-Grand-Automata / FGA

Auto-battle app for F/GO Android
https://fate-grand-automata.github.io
MIT License
1.48k stars 271 forks source link

Allow choosing when to reset infinite lottery #853

Closed jackcmedia closed 3 years ago

jackcmedia commented 3 years ago

Preparation

Describe the feature

Issue description:

I'm currently doing the Battle in New York 2021 event, and wanted to test how FGA does the infinite lottery.

While having FGA spin during the 3rd lottery lineup, having retrieved the grand prize, I ran out of tickets without completely getting all the 3rd lineup rewards. At this moment, FGA reset the lottery lineup, starting the fourth and losing me some valuable rewards from the still incomplete 3rd lineup.

Reproducible steps:

1) Have obtained the grand prize from the current lottery lineup. 2) Have enough tickets to NOT clear the currently lottery lineup when spinning. 3) Let FGA spin for you. 4) FGA will reset the lottery lineup.

The ask:

Have a setting that tells FGA whether to reset the lottery lineup (or not) when running out of spins.

jackcmedia commented 3 years ago

Interesting... There is already a function to control this, through I can't find where to toggle it.

https://github.com/Fate-Grand-Automata/FGA/blob/732a831739a54e37c7e1fa35366c4353eb2464e4/scripts/src/main/java/com/mathewsachin/fategrandautomata/scripts/entrypoints/AutoLottery.kt#L34

jackcmedia commented 3 years ago

Silly me, I just needed a more recent version of FGA.