Fate-Grand-Automata / FGA

Auto-battle app for F/GO Android
https://fate-grand-automata.github.io
MIT License
1.45k stars 267 forks source link

It dosen't work at Galaxy Z Flip3 #883

Closed Whitenugget closed 2 years ago

Whitenugget commented 2 years ago

Preparation

FGO server

JP

FGA build number

1498

Describe the bug

Hello, I'm a user who recently changed his cell phone to Galaxy Z Flip3. I tried to use FGA at this summer event, but the script didn't work at all. (Case#1~#3) I thought the screen ratio was not 16:9, so I changed it to the full screen. This time, some skills worked, but command input failed because some were not recognized. (Case#4)

All z flip series have a 6.7-inch ratio of 22:9 2640×1080. I don't think this screen size will change even if the next model comes out. I would appreciate it if you could help users who use the device.

Video

Case#1 - Order change https://youtu.be/9nrzwcuSeJo Case#2 - Space Ishtar https://youtu.be/KHDbc6p_Rl8 Case#3 - Amiya Archet https://youtu.be/IkC_U5MQDHc (I did it manually to show you the skill selection screen.)

Case#4 - Full Screen https://youtu.be/jD1sg8md-i4 (It didn't work on the original screen. This is a situation where i filmed after turning the screen upside down.)

Device model

Galaxy Z Flip 3

Android version

11

Screen size

6.7inch ratio 22:9 2640×1080

RAM

8GB

MathewSachin commented 2 years ago

We could make CASE#4 work. It looks like for screens wider than 21:9, blue borders appear on the sides. FGA should be able to work if we adjust for this.

reconman commented 2 years ago

Isn't everything above 18:9 supposed to be full screen without borders?

MathewSachin commented 2 years ago

That should be, but I think DW didn't plan for wider than 21:9 yet, similar to how less wider than 16:9 also gets blue borders above and below.

A potential way to confirm this would be to create a 22:9 emulator instance.

Whitenugget commented 2 years ago

Thank you. I'm looking forward to the day when it's adjusted.

MathewSachin commented 2 years ago

Can you try the APK from this page for CASE#4: https://github.com/Fate-Grand-Automata/FGA/actions/runs/1246024929 and also post a debug mode video so I can confirm.

Whitenugget commented 2 years ago

Sorry for confusing. I scroll down and pressed the wrong button to close it, so I thought it would be okay if I opened it again. I needed to explain why the condition changed.

But sorry, I don't know how to proceed with the actions.

reconman commented 2 years ago

@Whitenugget at the bottom there's an APK link, triggering the download of a zip file containing the APK.

Whitenugget commented 2 years ago

https://youtu.be/kzgCtoehwB0

At first, fga couldn't choose a friend, so I was worried. But the battle went smoothly according to the input command, and when it continued, it seems to be okay considering that it made a good choice at once.