Fate-Grand-Automata / FGA

Auto-battle app for F/GO Android
https://fate-grand-automata.github.io
MIT License
1.46k stars 269 forks source link

Failed to determine card type on super-buffed Lancelot on T3 #920

Closed KagomeKagome closed 2 years ago

KagomeKagome commented 2 years ago

Preparation

FGO server

NA

FGA build number

1537

Describe the bug

On turn 3, I'm getting "failed to determine card type" error on Lancelot. It works every other turn, but it always fails on turn 3. I've added a video of what happens in turn 3 when Lancelot face cards are there.

It's happened on every Saber Wars 2 nodes I've done since I updated last night. It also happens on non-event nodes, so it has nothing to do with the bonus damage buffs Lancelot has plus the CE.

Buff order for Lancelot goes T1: Paracelsus Arts, Waver DEF, Waver ATK T2: Paracelsus Guts, Paracelsus NP Gain, Waver Crit, Skadi Quick, Skadi Quick Crit, Lancelot NP Gain (FALLS OFF START OF T3), Crit Strength, Crit Star Drop, Crit Star Gather T3: Command Code ATK buff

I saw similar issues with buffs messing with card matching, but I noticed they were said to be fixed. I don't know how fringe this case is, but it's still happening seemingly. Every setting is default as far as I remember.

Team looks as such: Screenshot_2021 10 26_07 39 05 987

Video

https://streamable.com/246c5d

Device model

Bluestacks 5 Pie

Android version

9

Screen size

No response

RAM

No response

nantukoprime commented 2 years ago

Now seeing this issue regularly since the widescreen update on NA. Error crops up when selecting NP or cards, every turn.

Device: Pixel 4 XL

Android version 12

FGA Build 1551

Edit: Issue now clear. Was fixed as of 1557. Fix included reducing sensitivity of portrait recognition down, but not down enough for the recognition to confuse portraits.

DNLMow commented 2 years ago

Seeing same issue with Arjuna Alter with Merlin buster buff.

image image image image Untitled

Server: NA

Device: Bluestack (S20 Ultra) 1920x1080 240 DPI

FGA Build 1558

RAM 4G

Android version Bluestack 5.4.50.1009 N32

sdarkpaladin commented 2 years ago

Am getting this a lot when someone is super-buffed, usually with a single DPS double support Castoria team. Probably because the icons cover the top part of the card.

Shadd1 commented 2 years ago

u have some help to fixed this bug!?

Spiralem commented 2 years ago

I'm running on FGA canary-1575, and on BlueStack 4, but it seems like the issue is still present. Some additional image to help troubleshooting... First 2 pic is from the same turn, but different turn, while the 3rd pic is the buffs that is on the servant before command card selection. Edit: From the 4th (last) pic, it seems that there is no issue detecting superbuffed Musashi... bug bug

reconman commented 2 years ago

Please try build 1579: https://github.com/Fate-Grand-Automata/FGA/suites/4705166993/artifacts/128891252

justinbridouille commented 2 years ago

Please try build 1579: https://github.com/Fate-Grand-Automata/FGA/suites/4705166993/artifacts/128891252

WhatsApp Image 2021-12-19 at 23 30 21

the problem is not solved in build 1579

atm153 commented 2 years ago

Also encountering the same issue with Dantes/Skadi/Skadi on build 1577 using Bluestacks 5/Android 9 on NA. Can't try 1579 as it looks like it was pulled.

I found a temporary workaround for my purposes at least, turning on "Skip servant face-card checks" prevents FGA from encountering the bug and lets it keep moving forward by just selecting the two leftmost cards.

DNLMow commented 2 years ago

Build 1579 fixed the arjuna issue I posted for me.

mpetrovic commented 2 years ago

Build 1579 fixed the issue for me as well. It is now selecting the buffed servant's cards and correctly setting up Brave chains.

reconman commented 2 years ago

@justinbridouille Try changing Lancelot to 3rd ascension, I bet it will work. His 1st ascension is currently too dark to detect properly.

I have a solution in mind for some better image matching strategy, but for now please test my suggestion.

lolcatzidk commented 2 years ago

I'm running on FGA canary-1575, and on BlueStack 4, but it seems like the issue is still present. Some additional image to help troubleshooting... First 2 pic is from the same turn, but different turn, while the 3rd pic is the buffs that is on the servant before command card selection. Edit: From the 4th (last) pic, it seems that there is no issue detecting superbuffed Musashi... bug bug

I am running the same comp as you, and I'm also having the same issues with cards not being detected. On the rare occasion that the battle goes to turn 4 and buffs are gone, cards are detectable again.

reconman commented 2 years ago

@lolcatzidk Update FGA

lolcatzidk commented 2 years ago

@lolcatzidk Update FGA

I downloaded it, but now my Bluestacks doesn't want to even open now.. Edit: I ran the app accidentally, and then Bluestacks didn't want to run. It just gets stuck at the loading screen.

Hebelios commented 2 years ago

Hey, I updated to 1597 and play on JP. It still doesn't seem to work for me. I'm running via Nox-Player.

I am running a Melusiné team in the Beast-Raid right now. Servant is in 1st sprite, cards are in 2nd sprite (now that I write it out that might be the problem?). [EDIT: As you can clearly see in the screenshot, cardsprites were in first sprite already. But the Saint-Graph was on 2nd, I've changed everything to first and will report how that goes)] [EDIT2: It seems to work now. So to everyone that sees the issue, please check that your servant has the same ascension-sprite in every option.]

It worked for a while when adjusting the similarity-value but then stopped again.

image

reconman commented 2 years ago

@Hebelios Using a different portrait or adjusting the similarity should have 0 effect. The servant detail screen is used for matching, which just contains the selected sprite.

And the Failed to Determine message should only appear if the similarity between the face cards and the detail sprite was below 50 %.

If something like this happens again, I'll need a video with debug rectangles, including the first round where the detail windows are opened.