fix: Use root path when building full destination

fidian commented 9 months ago

What is the purpose of this pull request?

[X] Bug fix
[ ] New Feature
[ ] Documentation
[ ] Other

Description

Previously this plugin would not do anything when you put your project's site files under a folder. See the root shared option. With this change, the user now can have source files in a folder that is not at the project root.

This may also fix FatehAK/vite-plugin-image-optimizer#30, since I am also using Vite 5.x.

Checks

[X] PR adheres to the code style of this project
[X] Related issues linked using fixes #number
[X] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[ ] Lint and build have passed locally by running pnpm lint && pnpm build
[X] Code changes have been verified in local
[X] Documentation added/updated if necessary

Additional Context

jonasgeiler commented 4 months ago

I think this is a small but very useful change. Would be cool if you could merge this, @FatehAK! I can confirm that this works for my project.

For now I have made a fork which implements this PR at @jonasgeiler/vite-plugin-image-optimizer

FatehAK commented 4 months ago

Sure, @jonasgeiler! I'll make a release with this shortly. It's been a hectic few months at work, and I apologize for not getting to this sooner.

jonasgeiler commented 4 months ago

@FatehAK wrote: Sure, (at)jonasgeiler! I'll make a release with this shortly. It's been a hectic few months at work, and I apologize for not getting to this sooner.

Sure! No worries. I'll delete my fork as soon as #32 and #28 are merged :) Take your time.

FatehAK commented 4 months ago

Thanks for the support @fidian and @jonasgeiler this change is now available in v1.1.8.

jonasgeiler commented 4 months ago

@FatehAK wrote: Thanks for the support (at)fidian and (at)jonasgeiler this change is now available in v1.1.8.

Thank you! Fork is deleted now :)

FatehAK / vite-plugin-image-optimizer