search

Fauntleroy / react-simple-dropdown

Non-prescriptive React.js dropdown toolkit
ISC License
225 stars 75 forks source link

Example in a separate branch makes it really hard to develop the dropdown #19

Closed marcysutton closed 8 years ago

marcysutton commented 8 years ago

Maybe I'm missing something, but having your example code in gh-pages and pointing to the npm module as source code makes it really hard to contribute back to the dropdown. I was hoping to work on the accessibility of this dropdown and I'm finding it impossible to work with. Having a working example you can run in a local server would make it a lot easier to contribute back to this component.

Fauntleroy commented 8 years ago

Hey Marcy, thanks for submitting your issue!

I've always had hella trouble with running the example as well, for the same reason. Ultimately it's because I was using the example for the gh-pages site, so I'd have to switch branches all the time and... ech.

LUCKILY, GitHub just released a new gh-pages feature which will make things way easier. I'll work on implementing that soon!

Fauntleroy commented 8 years ago

Hey @marcysutton, I just took care of this issue in master. Please try it out and tell me if it works for you!