search

FaustXVI / junit5-docker

Start docker containers from your junit tests
Apache License 2.0
54 stars 7 forks source link

Bug when i run tests in windows #64

Open zeroual opened 7 years ago

zeroual commented 7 years ago

capture

FaustXVI commented 7 years ago

I think its from our use of currentTimeMillis in our tests. The javadoc says :

Returns the current time in milliseconds. Note that while the unit of time of the return value is a millisecond, the granularity of the value depends on the underlying operating system and may be larger. For example, many operating systems measure time in units of tens of milliseconds.

We may have to find a way to tests that is more reliable… :/

zeroual commented 7 years ago

yeah , any way nobody use windows except me :joy:

FaustXVI commented 7 years ago

Does it happens every time ?

Xavier Detant

On 14 Dec 2016 12:01, "Abdellah ZEROUAL" notifications@github.com wrote:

yeah , any way nobody use windows except me 😂

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/FaustXVI/junit5-docker/issues/64#issuecomment-267006037, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-EH3g3yy5t1wl7Yzn-bqVwPbw4IoYNks5rH8x2gaJpZM4LMuyl .

vdemeester commented 7 years ago

@FaustXVI as a quick workaround, we could have it skipped when platform is windows ? :smiling_imp:

FaustXVI commented 7 years ago

@vdemeester or add a windows build on the CI ? :p

vdemeester commented 7 years ago

@FaustXVI oh yeah :angel: we should setup appveyor for that :angel:

FaustXVI commented 7 years ago

Created #66 for that :)

FaustXVI commented 7 years ago

As explained in #66, we can't have a way to test on windows easily :( I'll remove the milestone for now.