Fausto-Korpsvart / Gruvbox-GTK-Theme

A GTK theme based on the Gruvbox colour palette.
https://www.pling.com/p/1681313/
GNU General Public License v3.0
563 stars 41 forks source link

Unusually Tall Header Bar on Libadwaita apps. #2

Closed ScribeAwoken closed 4 months ago

ScribeAwoken commented 2 years ago

So I've found that this theme (and presumably your others, though I have yet to test them) seems to break the headerbar items in Libadwaita apps. More specifically, it makes any widgets in the headerbars for these apps unusually tall.

Note that I'm able to theme these apps by putting the gtk.css file for GTK4 in ~/.config/gtk-4.0. I have yet to see if it has the same effect with non-libadwaita GTK4 apps. I also had to make a few other tweaks in order for Libadwaita apps to properly follow the color scheme. My only changes were just a few color definitions based on this template from the GNOME gitlab

This does seem to be an upstream issue, since this shows up in the Graphite theme, so I don't know if this is something you would want to fix yourself, or if you would want to wait for an upstream fix that you could implement in your themes. I have already opened an issue on the Graphite theme, so it might be a good idea to keep an eye on that as well.

I've also attached three screenshots below demonstrating the issue across your theme and the original Graphite theme, and the properly-sized header bar that the apps use while using Libadwaita.

image

image

image

Fausto-Korpsvart commented 2 years ago

So I've found that this theme (and presumably your others, though I have yet to test them) seems to break the headerbar items in Libadwaita apps. More specifically, it makes any widgets in the headerbars for these apps unusually tall.

Note that I'm able to theme these apps by putting the gtk.css file for GTK4 in ~/.config/gtk-4.0. I have yet to see if it has the same effect with non-libadwaita GTK4 apps. I also had to make a few other tweaks in order for Libadwaita apps to properly follow the color scheme. My only changes were just a few color definitions based on this template from the GNOME gitlab

This does seem to be an upstream issue, since this shows up in the Graphite theme, so I don't know if this is something you would want to fix yourself, or if you would want to wait for an upstream fix that you could implement in your themes. I have already opened an issue on the Graphite theme, so it might be a good idea to keep an eye on that as well.

I've also attached three screenshots below demonstrating the issue across your theme and the original Graphite theme, and the properly-sized header bar that the apps use while using Libadwaita.

image

image

image

Greetings, @ScribeAwoken.

And yes, as expected, the change to Gnome 42 was going to bring a lot of problems with themes, but with the release, as far as I understand, not everything has been ported to 'libadwaita', I guess this will be gradual and that in future versions the complete change will be made.

I don't know what version of Fedora you are using, I have done my tests with Fedora-36, and I know that it is no longer possible to apply themes from '.themes' and that the new path is '.config/gtk.4.0/gtk.css', but in my tests I haven't had that problem, I should have a look again. With regard to the operation in non 'libadwaita' applications, the theme works normally, my tests have been with the theme 'Tokyonight', I have put the theme 'libadwaita' in its respective directory and the other themes in '.themes' and it has worked very well the integration to maintain a uniform theme between applications that are and that are not 'libadwaita'. But, you see, I don't know much about creating GTK themes, but I'm looking for a way to learn more about 'libadwaita' so I can make them work in these new versions of GNOME, I hope you have a little patience while I do some research and learn a bit, I guess many developers are doing the same to find a way to bring back theme customization to GNOME.

Thanks for reporting, it's very helpful.

These are some screenshots of my tests with the 'Tokyonight' theme, the tests are on GnomeOS and Fedora36, as you can see there are still small bugs that I hope to fix, and as you can see there are 'libadwaita' and non 'libadwaita' applications working with the same theme, even VSCode Flatpak has worked with the theme.

tokyonight-gnome42

ScribeAwoken commented 2 years ago

I'm also using the Fedora 36 beta.

If you are unable to replicate the issue, then I might try a few things on my end to see if I can find a fix for things. I'll report back with my findings

ScribeAwoken commented 2 years ago

Update: I'm having this issue regardless of style sheet, so I don't think this is an issue with the theme

Fausto-Korpsvart commented 2 years ago

That might explain why I can't reproduce the error, I've been trying, but I can't get it. Anyway I'm working on fixing the little bugs I have in Tokyonight, so I can adapt it to Grubvox, I've also used the Gnome style template in Gitlab to make some changes, but maybe I don't know enough to make the changes without errors happening xD, anyway I'm learning, and I hope to fix them soon to be able to upload a stable theme.

Anyway, thanks for reporting the bugs };-]

ScribeAwoken commented 2 years ago

No problem

Though I did find something that... might actually point things in the right direction

so I spun up a Fedora Silverblue VM and upgraded it from Fedora Silverblue 35 to Fedora Silverblue 36, and it seems like it's specifically Extensions Manager that has this issue...

except I see in your screenshot that it looks perfectly fine (though I see that you also use the normal Adwaita switch widget rather than the custom one)

so I think we have a possible lead here

ScribeAwoken commented 2 years ago

Okay scratch what I just said. the new GNOME text editor also has the thick top bar.

that said I'm tinkering with the theme a bit to see if I can find the culprit. I think I'm getting there.