Fausto-Korpsvart / Gruvbox-GTK-Theme

A GTK theme based on the Gruvbox colour palette.
https://www.pling.com/p/1681313/
GNU General Public License v3.0
563 stars 41 forks source link

Not working in GNOME 43 #20

Closed D3vil0p3r closed 4 months ago

D3vil0p3r commented 1 year ago

Hello, I always used this wonderful theme, but now that I upgraded GNOME to 43, it is not working anymore:

image

Is there the chance to make it compatible with GNOME 43?

Fausto-Korpsvart commented 1 year ago

Hello, I always used this wonderful theme, but now that I upgraded GNOME to 43, it is not working anymore:

image

Is there the chance to make it compatible with GNOME 43? I know, these days I'm working on adapting the themes for Gnome 43, next week I hope to be able to update most of them. Thanks for reporting.

D3vil0p3r commented 1 year ago

Thank you @Fausto-Korpsvart I would like to ask a question. I'm reading the description in https://www.pling.com/p/1681313/ but it is not clear for me how to handle the G42.zip file version. It has a single .css. It must be placed in $HOME/.config/gtk-4.0 and renamed as gtk.css so replacing the gtk.css of the non-G42.zip file?

Fausto-Korpsvart commented 1 year ago

Thank you @Fausto-Korpsvart I would like to ask a question. I'm reading the description in https://www.pling.com/p/1681313/ but it is not clear for me how to handle the G42.zip file version. It has a single .css. It must be placed in $HOME/.config/gtk-4.0 and renamed as gtk.css so replacing the gtk.css of the non-G42.zip file?

@D3vil0p3r the Gnome 42 file, which will be renamed to 43 when Gnome 43 is released, does not replace any non Gnome 42 theme files, it styles, specifically, applications that use GTK4 and Libadwaita, non-G42 applications use GTK3, most Gnome applications are written in GTK3, but with Gnome 42 now applications are written in GTK4 and Libadwaita, so GTK3 styles no longer apply to applications written in GTK4 and Libadwaita, that's why you need to place the G42 file in $HOME/. config/gtk-4.0 to apply the themes to GTK4 and Libadwaita applications only.

D3vil0p3r commented 1 year ago

Thank you for the answer @Fausto-Korpsvart Now what I did in my GNOME 43 is:

In your updates of your themes you will theme also things like: image

?

Fausto-Korpsvart commented 1 year ago

Thank you for the answer @Fausto-Korpsvart Now what I did in my GNOME 43 is:

  • Downloading the Gruvbox-Dark-B.zip and Gruvbox-Dark-B-G42.zip
  • Extracting the first one in /usr/share/themes and the second one in the current directory and I get Gruvbox-Dark-B.css
  • cp -rf Gruvbox-Dark-B.css /usr/share/themes/Gruvbox-Dark-B/gtk-4.0/gtk.css
  • Run the following commands:
    mkdir -p "${HOME}/.config/gtk-4.0"
    ln -sf "/usr/share/themes/Gruvbox-Dark-B/gtk-4.0/assets" "${HOME}/.config/gtk-4.0/assets"
    ln -sf "/usr/share/themes/Gruvbox-Dark-B/gtk-4.0/gtk.css" "${HOME}/.config/gtk-4.0/gtk.css"
    ln -sf "/usr/share/themes/Gruvbox-Dark-B/gtk-4.0/gtk-dark.css" "${HOME}/.config/gtk-4.0/gtk-dark.css"

And the theme now is working also on my GNOME 43.

In your updates of your themes you will theme also things like: image

?

Yes, you can perfectly do that, the problem is that in the GTK4 files that you put in the ~/.themes directory, many styles are not applied very well, some Title Bars are very tall or some buttons have a lot of padding, so the G42 file only overwrites the styles needed to fit the Gruvbox theme and leaving the rest of the default styles for the Libdawaita theme, pretty much what I'm trying to do is color and add only the styles needed, though I guess over time more apps will come to Libadwaita and the style sheets will have to be migrated to ~/config/gtk-4.0 which will make the style sheet bigger.

This is what Nautilus will look like ported to Gnome 43, only this is the Tokyonight version theme without borders. nautilus

And this is what Gnome Shell will look like adapted to Gnome 43. shell

This is obviously the Tokyonight theme, but it will be adapted for Gruvbox as well.

D3vil0p3r commented 1 year ago

@Fausto-Korpsvart your work for GNOME 43 is wonderful!!! Thank you! I hope to see available theme as soon as possible!

Fausto-Korpsvart commented 1 year ago

@Fausto-Korpsvart your work for GNOME 43 is wonderful!!! Thank you! I hope to see available theme as soon as possible!

Thanks for your support, I hope to start updating some themes next week, I'll try to start with Tokyonight and Gruvbox. Thanks again for your support }:-]

Fausto-Korpsvart commented 1 year ago

@Fausto-Korpsvart your work for GNOME 43 is wonderful!!! Thank you! I hope to see available theme as soon as possible!

@D3vil0p3r, The Tokyonight theme is ready and you can check it out now to get an idea of how it will look adapted for Gruvbox.

D3vil0p3r commented 1 year ago

@D3vil0p3r, The Tokyonight theme is ready and you can check it out now to get an idea of how it will look adapted for Gruvbox.

I think it works very well! The result on my system is the following:

image
D3vil0p3r commented 1 year ago

@Fausto-Korpsvart your work for GNOME 43 is wonderful!!! Thank you! I hope to see available theme as soon as possible!

@D3vil0p3r, The Tokyonight theme is ready and you can check it out now to get an idea of how it will look adapted for Gruvbox.

Hello mate! Is there some news about Gruvbox theme?

megascrapper commented 1 year ago

@Fausto-Korpsvart your work for GNOME 43 is wonderful!!! Thank you! I hope to see available theme as soon as possible!

@D3vil0p3r, The Tokyonight theme is ready and you can check it out now to get an idea of how it will look adapted for Gruvbox.

Hello mate! Is there some news about Gruvbox theme?

It's already out now. Just head over to the pling page.

D3vil0p3r commented 1 year ago

It's already out now. Just head over to the pling page.

Thank you mate. I confirm it works correctly.

@Fausto-Korpsvart I wish to make you a request: on Internet there are no updated themes based on red-colors. The ones that can be found online are too old and not maintained anymore. I appreciate a lot your taste and I would like you to ask if you can create a deep red-based theme for GNOME. For example one that was followed but not maintained anymore is https://github.com/rtlewis88/rtl88-Themes/tree/Abyss-Desktop-Theme-Icons-and-Folders: image

In your opinion is possible to create a GTK theme starting from this (that is not maintained anymore) with your wonderful taste?

khbsd commented 1 year ago

Just curious, has the Gnome Shell portion for this been finished? My GTK4 apps are themed correctly, but it seems like the notification bar/quick settings from the top bar are still blue.

EDIT: nvm, just figured it out. looks great! Thank you!