search

Fausto-Korpsvart / Gruvbox-GTK-Theme

A GTK theme based on the Gruvbox colour palette.
https://www.pling.com/p/1681313/
GNU General Public License v3.0
595 stars 39 forks source link

Black corners on drop-down menus #33

Closed Goosegit11 closed 5 months ago

Goosegit11 commented 1 year ago

https://www.reddit.com/r/gnome/comments/zubm5f/black_corners_on_rounded_gtk_themes_whats_the/ https://www.reddit.com/r/i3wm/comments/s2oceb/how_can_i_get_rid_of_black_color_behind_the_round/

I have this problem as well and I searched all over the internet for a solution, but I have not found one. Seems like the problem is not window manager or compositor, the problem is in your theme.

I use dwm and picom, and every drop-down menu have that weird black corners. Thunar, Gajim, Transmission-gtk and others

Actually there is a workaround - put the corner-radius in picom.conf to ~12, then these corners will be hidden, but some people don't want round windows, so it's kinda silly hack

image

Fausto-Korpsvart commented 1 year ago

https://www.reddit.com/r/gnome/comments/zubm5f/black_corners_on_rounded_gtk_themes_whats_the/ https://www.reddit.com/r/i3wm/comments/s2oceb/how_can_i_get_rid_of_black_color_behind_the_round/

I have this problem as well and I searched all over the internet for a solution, but I have not found one. Seems like the problem is not window manager or compositor, the problem is in your theme.

I use dwm and picom, and every drop-down menu have that weird black corners. Thunar, Gajim, Transmission-gtk and others

Actually there is a workaround - put the corner-radius in picom.conf to ~12, then these corners will be hidden, but some people don't want round windows, so it's kinda silly hack

image

As far as I understand, this is not a problem with the theme, but rather with the compositor or with some kind of effects that you have activated, for example blur.

I remember that in XFCE there was a similar problem with Plank Dock, a shadow appeared that showed all the desktop space used by the Dock elements, if I remember correctly, it was solved by disabling the compositor effects for the Dock and Panels, in Gnome something like this happens with Dash To Dock when you add the Blur effects extension, it shows square corners and not round as the theme has determined. I also remember having this problem with XmonadWM, the GTK themes with round corners had the corners squared by the Comptom or Picom compositor, I don't remember which version I was using back then, but it added the blur effect which made the corners show square and not round.

Anyway, I'm going to check it out and look for a solution.

Thanks for the report and for the support, and sorry for the delay in replying, work is taking away my time to dedicate to the project at the moment.

Goosegit11 commented 1 year ago

It's the same with or without the compositor. Can be fixed by picom with rounded corners, but then you'll have rounded corners on every window (not only drop-down menus). So it's just a workaround, not a solution

Fausto-Korpsvart commented 1 year ago

It's the same with or without the compositor. Can be fixed by picom with rounded corners, but then you'll have rounded corners on every window (not only drop-down menus). So it's just a workaround, not a solution

Well, I think there is no concrete solution for this, since these themes are made for Gnome WM, not for TWM, those elements that do not render well are the shadows that are handled from the GTK theme.

In the Reddit links I read something about excluding some GTK rules from the Picom settings so that this behavior doesn't occur, since Picom, for example, handles shadows and rounded corners from its own settings file, which conflicts with the shadows and decorations typical of the GTK theme. I haven't tried this solution yet due to lack of time, so I don't know if that option gives a way to handle this behavior.

The solution to completely avoid this would be to remove the rounded corners from the GTK theme, so it wouldn't conflict with the effects the composers provide.

Goosegit11 commented 1 year ago

So if you remove the shadows from the theme, it would be fine on TWMs?

Fausto-Korpsvart commented 1 year ago

So if you remove the shadows from the theme, it would be fine on TWMs?

Yes, and in fact I think it's the only solution for TWMs, but the problem is that it wouldn't work very well without the shadows on the Gnome desktop, that's why I can remove the leftovers in the themes.

I don't want to promise anything, because due to my work I can't dedicate much time as I would like to this project, but I will try to work a version without shadows for TWMs, first I have to do a lot of tests, because I have tried few TWMs like BSPWM, Awsome and QTile, but the one I liked the most is Xmonad, and this is the one I have used for more time.

So, as I said, no promises, but I'll try, as I have to update the Gnome themes for the moment.

Goosegit11 commented 1 year ago

Thank you, I'm willing to help with testing the TWM theme!

edofe99 commented 5 months ago

The problem persist in xfce. image

Goosegit11 commented 5 months ago

Not completed.

Fausto-Korpsvart commented 5 months ago

Not completed.

@ironhak, @Goosegit11.

As I have already explained, this is not a problem with the theme, it is a problem with the Compositor, if it is disabled it will always show that annoying black border, but if you turn it on it disappears and in its place there is a soft shadow.

Compositor disabled

XFCE-Compositor1

Compositor enabled

XFCE-Compositor2

edofe99 commented 5 months ago

Compositor, if it is disabled it will always show that annoying black border, but if you turn it on it disappears and in its place there is a soft shad

@Fausto-Korpsvart Hello thank's, but what's the difference of using Xfce + Compositor vs Xfce vs Xfce + Compton? Thank's