Fausto-Korpsvart / Gruvbox-GTK-Theme

A GTK theme based on the Gruvbox colour palette.
https://www.pling.com/p/1681313/
GNU General Public License v3.0
582 stars 41 forks source link

Some GTK application don't have window borders #75

Open blissartt opened 6 days ago

blissartt commented 6 days ago

Hi! I've noticed that some GTK application such as firefox, thunar file manager and virt-manager don't have colored window borders, while others like bleachbit, pika backup and even flatpak applications do. Even xfce dialogs have colored borders, but some apps don't.

I am on Arch Linux, using Xfce 4.18 with the picom compositor, the picom-git version built from source. bord bord1

Fausto-Korpsvart commented 2 days ago

It seems strange to me, as I've tried Firefox and it does accept the border theme, anyway, I'll check to see what's wrong, I hope you've made sure you've applied the themes correctly.

blissartt commented 2 days ago

Thank you! I have followed what you said about the installation in the README: "The themes work on versions 40 to 44 of the GNOME D.E. just follow the steps below for installation:

Download the themes packs and extract them Move the extracted files to the following paths: For GTK3: ~/.themes In this path you must move the entire theme folder. For GTK4: ~/.config/gtk-4.0 The files to move to this path can be found inside the theme directory in the gtk-4.0 folder, copy only the assets, gtk.css and gtk-dark.css files or create a symlinks.

Applying Themes from zip files

For GTK3, apply themes from Gnome Tweaks. For GTK4 applications it is only necessary to have moved the assets, gtk.css and gtk-dark.css files to the ~/.config/gtk-4.0 path, and if you notice that the theme has not been applied, just close and reopen the application"

I've downloaded the theme from pling, moved the whole folder into my /home/$USER/.themes folder, and copied the contents of gtk-4.0 into /home/$USER/.config/gtk-4.0, making sure I only copied the assets, gtk.css and gtk-dark.css files into the folder.

Tell me if I missed some steps. Thank you again!

Fausto-Korpsvart commented 1 day ago

Yes, it seems you have done it correctly, I don't understand why that is not working in some GTK applications, because for XFCE it is true that the theme is more generic and I haven't configured borders, at least not yet, but I see that there are applications that should have borders and don't have them, like Firefox, I'll check this week this problem and try to fix it for the next update.

Thanks for reporting.

blissartt commented 1 day ago

Thank you for your time! Should I mark this as closed? If you want some additional info, I see that xfce popus like the right click menu or the xfce-notifyd notification DO have borders, it's other xfce apps (as well as the ones that I mentioned in the first comment) like the settings, or the display app that seem to have this issue.

Thanks again!