Fausto-Korpsvart / Gruvbox-GTK-Theme

A GTK theme based on the Gruvbox colour palette.
https://www.pling.com/p/1681313/
GNU General Public License v3.0
533 stars 40 forks source link

Can we have less borders? #8

Closed dxps closed 2 months ago

dxps commented 2 years ago

@Fausto-Korpsvart

This is a great theme!

I am using the Graphite theme, but with minor customizations (such as stronger border for the active window). So this is how it looks: image

And with this GTK Theme (the Dark BL flavor): image

and the Dark B flavor: image

Can you address this, please?

Thanks a lot!

Update: I see that Gruvbox-Light version looks good, though. But I definitely prefer the Dark and borderless flavor. image

dxps commented 2 years ago

At the same time I'd have to understand what to do with G42 (Gnome 42 specific, I guess) file, which might actually be very relevant to my case (using Pop!_OS 22.04 LTS, GNOME 42.2).

Fausto-Korpsvart commented 2 years ago

@Fausto-Korpsvart

This is a great theme!

I am using the Graphite theme, but with minor customizations (such as stronger border for the active window). So this is how it looks: image

And with this GTK Theme (the BL flavor): image

Can you address this, please?

Thanks a lot!

Update: I see that Gruvbox-Light version looks good, though (while I'm still preferring borderless flavor). image

Hello, @dxps.

I understand what you're saying, I recently had a report regarding this little edge, and I'm considering removing it, so I'll test, and you'll see changes in the next update.

Regarding the file for Gnome 42, you should place the file in the path: '~/.config/gtk-4.0/' and rename it to 'gtk.css', with this done you don't need to apply it with Tweaks, the theme is applied automatically, but windows opened before applying the theme, must be closed and opened again for the theme to be applied.

As soon as I have some free time, I will update the README to make it less confusing to use the files.

Thanks for the suggestions and support };-]

dxps commented 2 years ago

Really appreciate the quick feedback @Fausto-Korpsvart ! :blush: And thanks for the details regarding Gnome 42 specific file. :pray:

Meanwhile, I could also try to create another flavor from what I currently have and use (as a lighter nordic) to such gruvbox influence.

Speaking about theming knowledge:

I leave it up to you whether to have this ticket open as a reminder or close it.

dxps commented 2 years ago

Regarding suggestions, if I may :blush: (things that I actually did on my customization of that Graphite nord flavor):

  1. While I love how that nice edge border looks, it actually gets "interrupted" on the corners in certain windows like Firefox. image

    • This is the reason I didn't use that border, but strongly increase the shadow of the active window, so that it's pretty distinctive even on darker backgrounds. Like this (with GitHub Dark theme on the upper part of the background): image
  2. The are people (myself included, ofc) that would rather prefer a less contrast (or less emphasized, or just some minimal symbols like -, +, x for the window icons).

    • These macOS influenced icons and their colors look like the most important things in the window.
    • For such audience, I guess a version to just have such different icons alternative would definitely help.
Fausto-Korpsvart commented 2 years ago

Really appreciate the quick feedback @Fausto-Korpsvart ! blush And thanks for the details regarding Gnome 42 specific file. pray

Meanwhile, I could also try to create another flavor from what I currently have and use (as a lighter nordic) to such gruvbox influence.

Speaking about theming knowledge:

  • As you also mentioned here, did you find any good references on how GTK theming can be done? I mean, besides the official gtk3 or gtk4 docs.
  • I guess I shall also find some time to spend on this topic to satisfy my OCD.

I leave it up to you whether to have this ticket open as a reminder or close it.

About theme documentation:

In fact, the links you have provided are the ones that helped me to start getting involved in GTK themes, there is very little documentation on how to get started, to review the documentation that already exists you must have some knowledge of CSS and study how GTK works, but outside all that documentation I have not found anything else.

The 'Widget Factory' and 'GTK Inspector' have also helped me a lot, but with the new changes that have been made thanks to 'libadwaita' I have to start reviewing all the documentation in more depth to understand the new theme creation operation.

Fausto-Korpsvart commented 2 years ago

Regarding suggestions, if I may blush (things that I actually did on my customization of that Graphite nord flavor):

  1. While I love how that nice edge border looks, it actually gets "interrupted" on the corners in certain windows like Firefox. image

    • This is the reason I didn't use that border, but strongly increase the shadow of the active window, so that it's pretty distinctive even on darker backgrounds. Like this (with GitHub Dark theme on the upper part of the background): image
  2. The are people (myself included, ofc) that would rather prefer a less contrast (or less emphasized, or just some minimal symbols like -, +, x for the window icons).

    • These macOS influenced icons and their colors look like the most important things in the window.
    • For such audience, I guess a version to just have such different icons alternative would definitely help.

You are right, this looks horrible in Firefox and some applications, it is part of the problems in GTK3, and I have been looking for a solution to be able to continue with the styles of my themes and that Firefox is not affected, but unfortunately I have not found it yet the solution; I use Brave and for web development I rarely use Firefox, so it doesn't affect me too much, but most of the Linux community uses Firefox as their main browser, so I'm still looking for a solution, which might be easy, but it's not I have enough knowledge about creating themes to find that solution.

Regarding the shadows, yes, I've thought about making them a little more noticeable, especially in the borderless themes, but these are things that I have to test and play with a little to see what those changes look like, anyway , thanks for your suggestions I will take them into account when I do the tests and, if I like them, you will see the changes in the following updates.

With the window control buttons, well, I think it is possible to make the version of standard icons, maybe in the next update I will put a version of standard icons to see how it is received by everyone, I suppose many want a version with normal icons.

Anyway, here's a test of the fixes for the next update: testing

dxps commented 2 years ago

Sounds great, thanks! Regarding borders differences GTK3/4 (and a nice shadowing as well), this WhiteSur-Nord-Theme is a source of inspiration.

dxps commented 2 years ago

For now, inspired by this theme and Gruvbox colors, I ended up having this variant on my side and I'm pretty happy with it. :blush: The purpose is to see what others might expect from such a theme (although things are subjective and you can't make everybody happy all the times). And now I see that I shall use the icon scheme that you have since it's consistent with the rest.

image

Fausto-Korpsvart commented 2 years ago

For now, inspired by this theme and Gruvbox colors, I ended up having this variant on my side and I'm pretty happy with it. blush The purpose is to see what others might expect from such a theme (although things are subjective and you can't make everybody happy all the times). And now I see that I shall use the icon scheme that you have since it's consistent with the rest.

image

Sorry for taking so long to respond, I've been quite busy.

It's great how you have achieved that minimalism, it looks really cool, and I think many may like it, minimalism is always great in desktop and working environments.

I really like this version a lot, very inspiring, I will see how to work on a third version that can be really borderless because your version looks great, I like that shadow work. I will try to make some time to work on that, or in my free time dedicate it to that new version, thanks for sharing your mod.

At the moment, I've already updated with the fixes for the treeview and the version with legacy buttons. };-]

dxps commented 2 years ago

No worries. Meanwhile, we got some very nice extension in the Gnome community: Rounded Windows Corners. I just tested and it's just lovely!

With minimal bordering (width of 1 and the same color as the window background) all the edges look great, and you can also control the shadow. I finally have everything - including the Terminal window - rounded. :man_dancing:

image

Fausto-Korpsvart commented 2 years ago

No worries. Meanwhile, we got some very nice extension in the Gnome community: Rounded Windows Corners. I just tested and it's just lovely!

With minimal bordering (width of 1 and the same color as the window background) all the edges look great, and you can also control the shadow. I finally have everything - including the Terminal window - rounded. man_dancing

image

You're right, finally, an extension that really helps with rounded corners, I'm going to try it out, thanks for the tip.

Your theme looks great, I really like that icon colour, it plays nicely with the Gruvbox Soft

Thanks for your support.

coodyme commented 2 years ago

wow, will be great if we have less border...

at nautilus i found a little orange at selected folder (left side) its ok? or must be another color?

Screenshot from 2022-08-15 08-52-27

another question, is there a way to reduce de border size?

Screenshot from 2022-08-15 09-04-50

Fausto-Korpsvart commented 2 years ago

wow, will be great if we have less border...

at nautilus i found a little orange at selected folder (left side) its ok? or must be another color?

Screenshot from 2022-08-15 08-52-27

another question, is there a way to reduce de border size?

Screenshot from 2022-08-15 09-04-50

@augustobritodev, yes, that's supposed to be the colour, it's to see the active directory in the sidebar, they also have the same colour, the title of the active tab and the active directory in the Files path bar.

Here are the variants of the theme, the Gruvbox-Dark-BL is the Borderless version, there is also Gruvbox-Dark-BL-Legacy-Buttons if you don't want the macOS-style window control buttons.

t3dium commented 1 year ago

yeah i personally use borderless for the gnome shell theme and with borders for apps, looks nice that way