search

Fausto-Korpsvart / Kanagawa-GKT-Theme

A GTK theme with the Kanagawa colour palette.
https://www.pling.com/s/Gnome/p/1810560
GNU General Public License v3.0
192 stars 4 forks source link

Corners of some windows not playing nicely with the border #4

Open CodeAndGin opened 1 year ago

CodeAndGin commented 1 year ago

Mostly title.

Certain programs like firefox and sublime are ending up with rounded borders, and then drawing over them because their corners aren't actually rounded:

firefox sublime

Other programs with square corners like kitty play nicely with the theme. kitty

I'm awful at messing around with GTK stuff, so I dunno if there's a simple fix or not.

(On an unrelated note, editing the sublime-theme I'm using to match the kanagawa colours, while time consuming, should work to match it up to the rest of the system, right?)

Fausto-Korpsvart commented 1 year ago

Mostly title.

Certain programs like firefox and sublime are ending up with rounded borders, and then drawing over them because their corners aren't actually rounded:

firefox sublime

Other programs with square corners like kitty play nicely with the theme. kitty

I'm awful at messing around with GTK stuff, so I dunno if there's a simple fix or not.

(On an unrelated note, editing the sublime-theme I'm using to match the kanagawa colours, while time consuming, should work to match it up to the rest of the system, right?)

There are certain elements that I still don't know how to modify, actually I don't know if I can, I've read some articles in which it refers to certain elements of third party applications, which can't be modified with CSS sheets; for example, in Sublime Text, what makes the rounded corners at the bottom not look good is the status bar, which is an element that I can't access to round, I guess because it is an element of the language in which the application has been written, since I tried with the Gnome widget inspector and I have not been able to access; this with respect to Sublime Text.

Group 1

Regarding Firefox, it's something of the same, many of us expect more integration with Linux, Wayland support, there are those who ask for a version written in GTK4, but there are many drawbacks.

This is one of the problems with using a border on windows and trying to round the bottom corners in GTK3, that in third party applications you can't control the styles of all elements; something that in GTK4 seems to be solved and already supports rounded corners.

I can see from the screenshot you show that you are using the Dark Firefox theme, you can use the System Theme - auto and check if you have the gtk-engine-murrine package installed, this fixes some bugs when rendering themes.

I'm still reading documentation to understand more about GNOME theme creation and testing, as soon as I find them I will fix every bug, but I don't want to promise anything, because from what I understand these are old problems in GTK3.

Thanks for reporting and your support.

CodeAndGin commented 1 year ago

I just came across an extension that can round all corners that seems to work well with firefox and sublime text (https://github.com/yilozt/rounded-window-corners). The downside being that it overwrites the theme and draws its own borders and doesn't have an active/inactive border colour difference. Might be worth a look?

Fausto-Korpsvart commented 1 year ago

I just came across an extension that can round all corners that seems to work well with firefox and sublime text (https://github.com/yilozt/rounded-window-corners). The downside being that it overwrites the theme and draws its own borders and doesn't have an active/inactive border colour difference. Might be worth a look?

I know the extension, in fact I use it to round the Kitty terminal because I use it without window borders, you know, to use the screen space well, what I have found is that you can make it not apply for LibAdwaita and LibHandy, you just have to enable the Skip LibAdwaita Applications, Skip LibHandy Applications options; that for applications that use these libraries, but I haven't found a way to still use the stylesheet border, the extension completely removes the default styles in applications that use its settings.

I also found this: Mutter Rounded which adds default rounded corners to the Mutter composite, I tested it on Fedora 36, but I haven't tested it yet for Fedora 37 or Arch Linux; I'll leave it up to you if you want to try it.

CodeAndGin commented 1 year ago

Just had a look, it's out of date, and the fork that is patched for mutter 43 is a clone of the git repo you linked, which has no build instructions for Arch. I'm not versed enough in PKGBUILDS to go messing about to try and get the forked patch lmao so I'll stick with what I have for now