Fausto-Korpsvart / Tokyonight-GTK-Theme

A GTK theme based on the Tokyo Night colour palette.
https://www.pling.com/p/1681315/
GNU General Public License v3.0
470 stars 30 forks source link

Firefox theme windows corner issue ? #22

Closed bbrx94 closed 2 weeks ago

bbrx94 commented 1 year ago

Hello,

It's to make a Firefox theme (like Whitesur theme) ? How can I fix this problem

image

Best regards,

Fausto-Korpsvart commented 1 year ago

bbrx94

Greetings, @bbrx94

What distro are you using? I'm on Fedora 36 and I don't have that problem, in the distro I've tried I haven't seen that error, the distros are Manjaro, OpensSUSE, PopOS and some others with Gnome by default. And no, I'm not making a Firefox theme like WhiteSur.

Here is a screenshot of Firefox on Fedora. Firefox

bbrx94 commented 1 year ago

Oh, ok, I'm using Arch Linux, please get info. image

bbrx94 commented 1 year ago

Greetings,

I also tried to reset Firefox settings to see, from "Help" -> "Fix Firefox" and same problem. I have the issue with libreWolf too (based on Firefox)

Best regards, B.

Fausto-Korpsvart commented 1 year ago

Greetings,

I also tried to reset Firefox settings to see, from "Help" -> "Fix Firefox" and same problem. I have the issue with libreWolf too (based on Firefox)

Best regards, B.

Alright, I don't think it's a problem with the Firefox or LibreWolf settings, it's obviously a problem with the theme; I'm going to check what's going on with this error because I haven't had this problem before. I will check and make an update when I find the error.

Thanks for reporting and for the support. };-]

bbrx94 commented 1 year ago

OK thanks, also how I can get a same position of buttons on left side? what I need to change in css and which files? In this capture, you have Nautilus / Gedit / VS Code (at bottom) image

If I put buttons at right, no problem, it's strange? image

Fausto-Korpsvart commented 1 year ago

OK thanks, also how I can get a same position of buttons on left side? what I need to change in css and which files? In this capture, you have Nautilus / Gedit / VS Code (at bottom) image

If I put buttons at right, no problem, it's strange? image

I can add the padding when the icons are on the right side to be the same as when they are on the left side, but this affects only native GNOME applications, I have to do some research to know how to apply this padding to applications that are not written in GTK, because I guess that's why VSCode doesn't apply this padding, I don't use the native VSCode window, actually I almost don't use VSCode, so I didn't notice it, but I have noticed it in other applications, like Brave Browser. So, in the next update I will try to solve this problem with non-native applications, but you will see the change in the native GNOME applications.

bbrx94 commented 1 year ago

Great, thanks. For Evolution (is not native GTK?) and Firefox is a same than VS Code

image

Fausto-Korpsvart commented 1 year ago

Great, thanks. For Evolution (is not native GTK?) and Firefox is a same than VS Code

image Which version of Evolution are you using? Because I just installed it and it works fine for me, it respects the theme. evolution

bbrx94 commented 1 year ago

Greetings,

Yes, it's a same version. image

I saw some theme require this : gtk-engine-murrine gtk-engines (I tried and it's change).

Regards, B.

bbrx94 commented 1 year ago

For Firefox, I tried to adapt Whitesur and for the moment I don't change icons yet

image

So currently I'm in this configuration

image

Fausto-Korpsvart commented 1 year ago

For Firefox, I tried to adapt Whitesur and for the moment I don't change icons yet

image

So currently I'm in this configuration

image

I have updated to fix the position of the window control buttons and the title bar, it seems that it is not what I thought, as you can apply styles to the Headerbar and the Titlebar, now it is a bit more similar to the native GTK applications.

Unfortunately, I haven't been able to reproduce the Firefox problem yet, but I'm still looking for a solution for the rounded corners, when I find it I'll update again.

And thanks for reminding me about the gtk-engine-murrine and gtk-engines dependencies, I will put in the description that it is necessary to install these packages to avoid some problems.

Again, thanks for your support and for reporting bugs to make the theme look better.

bbrx94 commented 1 year ago

Thanks you, nice job!

XMelph commented 1 year ago

I'm currently facing the same issue on Fedora 36. I still don't understand exactly why, as before the theme worked fine on this distro.

Fausto-Korpsvart commented 1 year ago

I'm currently facing the same issue on Fedora 36. I still don't understand exactly why, as before the theme worked fine on this distro.

I still don't understand the origin of this error, in my tests with virtual machines I don't have this problem, I have reinstalled the virtual machines to have the latest versions and even in Fedora 37 I don't have this problem in Firefox; I am using Fedora 36 as my main system and Firefox applies the themes well.

I will continue to investigate where this error comes from to fix it as soon as possible, thanks for reporting it.

bbrx94 commented 1 year ago

Hello,

I have news about Firefox problem FF menu round corner on Arch Linux (Wayland / Gnome), get a look here please ;) https://bbs.archlinux.org/viewtopic.php?id=280099

Fausto-Korpsvart commented 1 year ago

Hello,

I have news about Firefox problem FF menu round corner on Arch Linux (Wayland / Gnome), get a look here please ;) https://bbs.archlinux.org/viewtopic.php?id=280099

Interesting, I need to check this out in detail to see how to apply this. Thanks for taking the time to do the research and for sharing the information, it is very useful.

rafay99-epic commented 1 year ago

I'm currently facing the same issue on Fedora 36. I still don't understand exactly why, as before the theme worked fine on this distro.

Brother I am using Firefox with Fedora 38, and I did not see this issue, but it is interesting.

wsouto commented 1 year ago

Brother I am using Firefox with Fedora 38, and I did not see this issue, but it is interesting.

That's odd. I'm on 38 too, and having this issue so that it might not be just the theme. This is the only theme I have ever used in GNOME, so I like seeing this bug squashed.

wsouto commented 1 year ago

The thing is that I'm using Firefox Developer Edition (currently version 114.0b9) and the corners are buggy, but on default Firefox (113.0.1) it's showing as expected, so it's not the theme.

Thanks for making a great theme!