search

Fausto-Korpsvart / Tokyonight-GTK-Theme

A GTK theme based on the Tokyo Night colour palette.
https://www.pling.com/p/1681315/
GNU General Public License v3.0
470 stars 30 forks source link

Compatibility with GNOME 44 #35

Closed D3vil0p3r closed 2 weeks ago

D3vil0p3r commented 1 year ago

Is this theme (and other theme you created) compatible with the new GNOME 44?

SteinGaming commented 1 year ago

Is this theme (and other theme you created) compatible with the new GNOME 44?

@D3vil0p3r doesn't seem like it does, tried Tokyonight-Strom-BL which causes broken shadows outside of the window

D3vil0p3r commented 1 year ago

Yes, just look my window: image

Skydeke commented 1 year ago

Pretty sure this is related to https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5857

Fausto-Korpsvart commented 1 year ago

Yes, just look my window: image

Greetings all.

This problem does not seem to be theme related, as far as I have investigated, the problem is with Mutter. Even the theme I based it on, Graphite seems to have the same problems, it's not lack of support for Gnome 44, the problem is with Mutter and related to the way it renders elements.

Here the origin of the problem seems to be better explained.

Here is the temporary solution offered by @vinceliuice

Thank you for reporting and for your support, I know I have not been very active in the project lately, but it is due to my work that I have not had much time, I will soon make an update to fix the problems with Gnome Shell that many have reported.

I appreciate your patience and support.

D3vil0p3r commented 1 year ago

Thank you for the answer @Fausto-Korpsvart

I applied the temporary solution but it does not work (in Xorg). I tested it on your Tokyo Night theme: image

I tested also the Graphite theme of @vinceliuice and it works correctly also without that temporary fix: image

Fausto-Korpsvart commented 1 year ago

Thank you for the answer @Fausto-Korpsvart

I applied the temporary solution but it does not work (in Xorg). I tested it on your Tokyo Night theme: image

I tested also the Graphite theme of @vinceliuice and it works correctly also without that temporary fix: image

I have already updated the Graphite repository, and I am working on the new theme update, I am checking and there seems to be no errors. I hope to be able to do the Tokyonight update next week.

Gnome Terminal gnome-terminal

D3vil0p3r commented 1 year ago

@Fausto-Korpsvart thank you man. The new updates will come also for other your themes (i.e., Gruvbox)?

Fausto-Korpsvart commented 1 year ago

@Fausto-Korpsvart thank you man. The new updates will come also for other your themes (i.e., Gruvbox)?

@D3vil0p3r, yes, for all themes.

Fausto-Korpsvart commented 1 year ago

Tokyonight is now up to date, I would appreciate reports to see if there are still bugs to fix.

D3vil0p3r commented 1 year ago

I'm currently abroad but I will try to get any random computer on my sight for testing it. I will trst Tokyo Night and Gruvbox.

D3vil0p3r commented 1 year ago

@Fausto-Korpsvart I tested the latest commit files both for Tokyo Night and Gruvbox themes, but I'm still getting the same issue. Here the example on Tokyo Night theme:

Kitty terminal: image

I'm using an Arch-based distro with GNOME 44.1 Xorg and the Tokyo Night commit I'm using is the latest one (53.a25fd5e8). For Gruvbox is the latest one too (50.c7a85272).

By GNOME Terminal it works correctly. I don't have that issue. I'm noting that it occurs mainly for those windows developed by Python GTK (indeed Kitty terminal is developed by Python). Indeed if I open some GTK windows developed by Python, I get the following behavior: image

Fausto-Korpsvart commented 1 year ago

@Fausto-Korpsvart I tested the latest commit files both for Tokyo Night and Gruvbox themes, but I'm still getting the same issue. Here the example on Tokyo Night theme:

Kitty terminal: image

I'm using an Arch-based distro with GNOME 44.1 Xorg and the Tokyo Night commit I'm using is the latest one (53.a25fd5e8). For Gruvbox is the latest one too (50.c7a85272).

By GNOME Terminal it works correctly. I don't have that issue. I'm noting that it occurs mainly for those windows developed by Python GTK (indeed Kitty terminal is developed by Python). Indeed if I open some GTK windows developed by Python, I get the following behavior: image

That's quite strange, I don't understand the source of the problem, the theme I use as template is Graphite and I have updated to its latest version.

What Arch based distribution are you using? Because I test on different distros and I haven't seen this problem, in fact I use Kitty and I haven't seen this problem after the update.

I want to test on the distro you are using with Xorg to find the source and fix the bug. Here is a screenshot of kitty with Tokyonight Borderless version on Wayland kitty

D3vil0p3r commented 1 year ago

Thank you for the answer @Fausto-Korpsvart

The distro I'm using is Athena OS that is a pentesting OS Arch-based I made for Cyber Security professionals that use some of your themes. I invite you to download the ISO of the beta version that will be released in the next days and that has this issue (since it is based on GNOME 44): https://www.dropbox.com/s/dlf9klsujzzyj6e/athena-2023.05.15-x86_64.iso?dl=0

Assign to it at least 4 GB RAM, 20 or 30 GB of disk space and 2 cores. When the Live ISO will run, a window appears, click "Online Installer" and on "Themes" section, select BlueEyesSamurai (Tokyo Night based) or CyborgGruvbox (Gruvbox GTK based).

If you would like to keep a closer contact with me, you can reach me on Athena OS Discord server: https://discord.gg/DNjvQkb5Ad

JoZ3 commented 1 year ago

same issue here: imagen I use manjaro in its last version with gnome 44.1 and X11, it happens with all the applications that are in qt and java, I have tried with the themes gruvbox, kanagawa and tokyonight, with the versions with borders and without borders. Trying with other themes from other developers I found that with this theme the problem of the borders does not happen: https://gitlab.com/SafwanLjd/BetterGruvbox

Fausto-Korpsvart commented 1 year ago

same issue here: imagen I use manjaro in its last version with gnome 44.1 and X11, it happens with all the applications that are in qt and java, I have tried with the themes gruvbox, kanagawa and tokyonight, with the versions with borders and without borders. Trying with other themes from other developers I found that with this theme the problem of the borders does not happen: https://gitlab.com/SafwanLjd/BetterGruvbox

@JoZ3, you are right, I have tried with Manjaro Gnome and I notice that the problem is only when using X11, I must check completely the issue, because in Wayland I have not noticed any problem.

Thanks for reporting, I will make a new update when I have solved the problem.

Fausto-Korpsvart commented 1 year ago

Updated. Please check and report if the error persists }:-]

Fausto-Korpsvart commented 1 year ago

Thank you for the answer @Fausto-Korpsvart

The distro I'm using is Athena OS that is a pentesting OS Arch-based I made for Cyber Security professionals that use some of your themes. I invite you to download the ISO of the beta version that will be released in the next days and that has this issue (since it is based on GNOME 44): https://www.dropbox.com/s/dlf9klsujzzyj6e/athena-2023.05.15-x86_64.iso?dl=0

Assign to it at least 4 GB RAM, 20 or 30 GB of disk space and 2 cores. When the Live ISO will run, a window appears, click "Online Installer" and on "Themes" section, select BlueEyesSamurai (Tokyo Night based) or CyborgGruvbox (Gruvbox GTK based).

If you would like to keep a closer contact with me, you can reach me on Athena OS Discord server: https://discord.gg/DNjvQkb5Ad

@D3vil0p3r, Interesting, I'll have a look. For my attempts to learn some cybersecurity I've been using Fedora Security Lab, I've tried the classics before, Kali and Parrot, so far I haven't tried Black Arch based, sounds very interesting, I'll check it out, thanks }:-]

JoZ3 commented 1 year ago

Updated. Please check and report if the error persists }:-]

thanks mate :), tested with Gruvbox and Tokyo-Night and works fine, with Kanagawa the issue continue.

Fausto-Korpsvart commented 1 year ago

Updated. Please check and report if the error persists }:-]

thanks mate :), tested with Gruvbox and Tokyo-Night and works fine, with Kanagawa the issue continue.

I haven't updated Kanagawa yet, it will be next along with Nightfox }:-]

D3vil0p3r commented 1 year ago

@Fausto-Korpsvart thank you. I'm testing theme and it seems Tokyo Night and Gruvbox themes are working correctly now also on Athena OS and Xorg. Just one note for Gruvbox: on "themes" folder the names of subfolders contain typo "Grubvox" instead of "Gruvbox": image

JoZ3 commented 1 year ago

@Fausto-Korpsvart thank you. I'm testing theme and it seems Tokyo Night and Gruvbox themes are working correctly now also on Athena OS and Xorg. Just one note for Gruvbox: on "themes" folder the names of subfolders contain typo "Grubvox" instead of "Gruvbox": image

haha, I hadn't noticed that detail :) imagen

Fausto-Korpsvart commented 1 year ago

@Fausto-Korpsvart thank you. I'm testing theme and it seems Tokyo Night and Gruvbox themes are working correctly now also on Athena OS and Xorg. Just one note for Gruvbox: on "themes" folder the names of subfolders contain typo "Grubvox" instead of "Gruvbox": image

Yeah, sorry, I really knew I had spelt it wrong and with the bug fixes I completely forgot to change the name, I only realised minutes after I had done the update xD I will change the name when I upload the Gruvbox Medium Theme in the next few days.

Thanks for reporting }:-]

D3vil0p3r commented 1 year ago

Is it correct I have these blue and green colors in Gruvbox theme? image

image

Fausto-Korpsvart commented 1 year ago

Updated. Please check and report if the error persists }:-]

thanks mate :), tested with Gruvbox and Tokyo-Night and works fine, with Kanagawa the issue continue.

Kanagawa theme updated, @JoZ3.

D3vil0p3r commented 1 year ago

I see also the colors of Gruvbox theme have been fixed. Thank you. I think this issue can be closed. I will follow the issue I opened yesterday about Nightfox theme at https://github.com/Fausto-Korpsvart/Nightfox-GTK-Theme/issues/3

Fausto-Korpsvart commented 1 year ago

I see also the colors of Gruvbox theme have been fixed. Thank you. I think this issue can be closed. I will follow the issue I opened yesterday about Nightfox theme at Fausto-Korpsvart/Nightfox-GTK-Theme#3

Yes, the Nightfox theme will be updated tomorrow or in the next few days, as I have a busy day tomorrow and I hope to dedicate some time to update and upload it, but it is the next theme to be updated.

Thanks for your support }:-]

D3vil0p3r commented 11 months ago

Hey @Fausto-Korpsvart can you try to please open a GTK window with Tokyo Night theme and then press on the keyboard ALT + Print keys? Usually this key combo is used for getting the screenshot of the active window.

What I note is that, if you do that, it saves the screenshot of the active window but the saved image keeps a transparent border, for example:

image

The problem with that is: when a user takes a screenshot of the active window and it copies and pastes the image somewhere (for example in a document), the image will appear a little smaller than the original one, so the user is forced to remove manually (i.e., by Photoshop) this transparent border.

I think it is related to the famous outer shadow around the windows we had at the beginning as issue, and now that is reduced to 0, something invisible should be remained there.

Fausto-Korpsvart commented 11 months ago

Hey @Fausto-Korpsvart can you try to please open a GTK window with Tokyo Night theme and then press on the keyboard ALT + Print keys? Usually this key combo is used for getting the screenshot of the active window.

What I note is that, if you do that, it saves the screenshot of the active window but the saved image keeps a transparent border, for example: image

The problem with that is: when a user takes a screenshot of the active window and it copies and pastes the image somewhere (for example in a document), the image will appear a little smaller than the original one, so the user is forced to remove manually (i.e., by Photoshop) this transparent border.

I think it is related to the famous outer shadow around the windows we had at the beginning as issue, and now that is reduced to 0, something invisible should be remained there.

Greetings, @D3vil0p3r.

Yes, I know what you're talking about, when I made the presentation image of the themes I ran into this problem and had to edit some images to remove that border, and that's extra work.

I am currently working on many improvements, one of them is the change of base theme, I plan to change to the Jasper theme from the same author of Graphite, I am testing and changing things in the source code to generate the themes from the scss sheets. Because of work I can't keep track of each theme separately by editing each theme from the css sheets, so it's time to automate this work a bit to support and update more often.

I plan to make the necessary changes to keep the current styling, but leave many others as default, this includes the shadows and borders of the borderless themes.

So, give me some time, I hope to finish all this in this week, work permitting, and do the necessary tests to update this theme as soon as possible.

Thanks for your support

D3vil0p3r commented 11 months ago

Thank you. If there are some tasks we could be useful, please tell us.