Incorrect Sidebar Color in GTK4 Applications

Fausto-Korpsvart / Tokyonight-GTK-Theme

A GTK theme based on the Tokyo Night colour palette.

https://www.pling.com/p/1681315/

GNU General Public License v3.0

470 stars 30 forks source link

Incorrect Sidebar Color in GTK4 Applications #49

Closed uosyph closed 2 weeks ago

uosyph commented 6 months ago

There's an issue with the sidebar color in various GTK4 apps. Initially, I thought it was specific to Nautilus and opened a pull request to address it. However, upon further testing, it seems that the problem extends to all GTK4 applications.

nautilus

firefox bookmarks

settings

characters

eldskald commented 6 months ago

Is this Gnome 45? It's not supported yet.

uosyph commented 6 months ago

Yeah it is, that's why! Thanks for clarifying.

Fausto-Korpsvart commented 6 months ago

I am sorry for the delay in replying and updating, but due to family issues I have not been able to be very active in the project.

I have already solved this problem and it is currently working in Gnome 45, but I haven't done the update yet because I want to fix small details that, as I said, due to some family issues I haven't had the time to solve.

This is a screenshot of how this problem is already solved.

I want to dedicate this week to fix small bugs in GNOME and XFCE, I also want to check the other desktops so I can update and make everything work properly.

Sorry this is taking so long and thanks for your understanding and patience.

TN-Testing

Fausto-Korpsvart commented 6 months ago

Here is a link for you to test some versions of the theme, you can see and test the theme and tell me if something is wrong, I don't want to update the source code yet so when I upload it some bugs are fixed, for that reason I share this link, I hope you like the progress and any problem you see let me know to fix bugs.

Tokyonight-Testing

uosyph commented 6 months ago

I'm sorry to hear about your family issues, I hope things get easier for you soon. I appreciate your update and understand that personal matters take precedence.

I'll check out the test version in the next couple of days and give you a heads up if anything seems off.

Thanks a bunch for your work, take care!

smokingsnakes83 commented 6 months ago

Here is a link for you to test some versions of the theme, you can see and test the theme and tell me if something is wrong, I don't want to update the source code yet so when I upload it some bugs are fixed, for that reason I share this link, I hope you like the progress and any problem you see let me know to fix bugs.

Tokyonight-Testing

Awesome, TKS!

eldskald commented 6 months ago

That first picture is the bottom of a kitty terminal, the second is the bottom of Gnome's settings. You can see that kitty has weird corners, it's like its borders have a corner radius but the contents of the window doesn't while the other app's corners are just normally rounded. It's happening only on the bottom corner, the ones on the top are fine.

Kitty seems unaffected by the settings on Gnome Tweaks, so I'm assuming it's GTK 4.0, unlike every other application I saw that has normal rounded corners and were affected by these settings. Pretty much every app that's not by Gnome looks like this with the exception of the web browser. Spotify and random games look like this, I also tried alacritty and it looked like this as well. None of them were affected by the settings on Gnome Tweaks as well, so far only the apps that aren't affected by it have these glitched corners on the bottom.