search

Faustvii / beth-leaderboard

beth stack leaderboard app
https://beth-leaderboard.fly.dev/
5 stars 1 forks source link

Change teams colors to sofa/stool #54

Open djonn opened 3 months ago

djonn commented 3 months ago

We still use black/white teams even though we have changed discs multiple times since then.

I think we should update the text for the team "names" to be based on the seating locations of the teams rather than the colors.

Not sure if this should just be a change of the texts shown on the website or if we should rename in our code + db schema 🤔

Kechr commented 3 months ago

Not sure if this should just be a change of the texts shown on the website or if we should rename in our code + db schema

Really depends on how thorough we want to be - Personally, I think we should rename it across the entire system, just to avoid confusion 🤷🏽

Faustvii commented 3 months ago

The even bigger option would be to introduce a "location/office" concept, so users can be assigned to a location and then we can have different "team/seat names" for different locations.

Kechr commented 3 months ago

@Faustvii Yagni? - or are we planning on adding the other games soon™️ so other offices can use the leaderboard (assuming they will use it)?

Faustvii commented 3 months ago

I think they wanted to use it in Aalborg for some other games, but yeah it was to start some of the "prep" work I guess. I have heard other people here at the office wants it for other games 😄 But I agree it is way overkill.

djonn commented 3 months ago

I think that the easiest solution by far for multiple other games / other offices is to do a second deployment. So we should consider if it's worth it in complexity to have it be part of a single deployment

srensom commented 3 months ago

Based on your comments I suggest that this task is remade into the first step of the bigger plan of getting a more generic Team/Position solution.

  1. (This issue) Make a new data field called "position". For us this is Sofa or Stool but implement it in a way that allows future games to easily use this if a position is relevant in their game. Add the field to game registration and make stats show this instead of the current black/white thing. Don't migrate color data, keep it as-is, this is a new thing and should be treated as such.
  2. Make "team black" and "team white" into "team 1" and "team 2" and allow different colors to be chosen for each team
  3. Remake colors. Allow the 6 different colors when registering and showing who won as what actual color they played with.
  4. Some magic cutoff of "faulty" color data. Probably associated with a new season. Allowing the color data to be useful. The current black/white is just used random as a team 1/ team 2 kinda thing. ?. Introduce the office/location concept

What are your takes @Faustvii @djonn

djonn commented 2 months ago

I can't really tell how much code-complexity I recon this will add, but I am a bit worried about the complexity vs. the added value from that complexity 🤔