Open stackmystack opened 3 days ago
While checking the deprecation logs for == and !=, I stumbled upon a deprecation warning in the to_sql visitor: https://github.com/Faveod/arel-extensions/blob/master/lib/arel_extensions/visitors/to_sql.rb#L115 (but it's also present in other visitors).
==
!=
to_sql
It seems that this is wrong, because o.separator is anode, and naturally it's always != 'NULL'. Do we want to restrain the check for the cases where o.separator.is_a? String only? Or simply call to_s ... ?
o.separator
!= 'NULL'
o.separator.is_a? String
to_s
While checking the deprecation logs for
==and!=, I stumbled upon a deprecation warning in theto_sqlvisitor: https://github.com/Faveod/arel-extensions/blob/master/lib/arel_extensions/visitors/to_sql.rb#L115 (but it's also present in other visitors).It seems that this is wrong, because
o.separatoris anode, and naturally it's always!= 'NULL'. Do we want to restrain the check for the cases whereo.separator.is_a? Stringonly? Or simply callto_s... ?