search

Faveod / arel-extensions

Extending Arel
MIT License
142 stars 24 forks source link

Improvements for strftime #35

Closed akimd closed 3 years ago

akimd commented 3 years ago

I believe there are several issues to fix in the handling of strftime/format. There's also a number of things I don't understand well. For instance mssql is not dealt with the same way as the other RDBMS:

module ArelExtensions
  module Visitors
    module MSSQL

instead of

module ArelExtensions
  module Visitors
    class Arel::Visitors::PostgreSQL

Why this difference? I believe it's a mistake, introduced in cf49f1124dc76662fd7d0d143a0a7f997f9c41d9.

Anyway, I don't understand the meaning of

module ArelExtensions
  module Visitors
    class Arel::Visitors::PostgreSQL

Is there a difference with just

class Arel::Visitors::PostgreSQL

?

The test suite is running here: https://travis-ci.org/github/Faveod/arel-extensions/builds/743934528