search

Faveod / arel-extensions

Extending Arel
MIT License
142 stars 24 forks source link

Json fixes #51

Closed akimd closed 2 years ago

akimd commented 2 years ago

I have failed to reenable the JSON test. The very first test fails as soon as you activate it.

However, these fixes have been used with success to fix genuine problems. We should merge and release.

commit e95fcaf02a59d1251239b1410bafad1e60ff0cc4
Author: Akim Demaille <akim.demaille@gmail.com>
Date:   Wed Jan 19 15:58:04 2022 +0100

    test: unskip json tests

diff --git a/test/with_ar/all_agnostic_test.rb b/test/with_ar/all_agnostic_test.rb
index 4a62486..ec9e039 100644
--- a/test/with_ar/all_agnostic_test.rb
+++ b/test/with_ar/all_agnostic_test.rb
@@ -777,7 +777,6 @@ module ArelExtensions
       end

       def test_json
-        skip "Can't be tested on travis"
         # creation
         assert_equal 'Arthur', t(@arthur,Arel.json(@name))
         assert_equal ["Arthur","Arthur"], parse_json(t(@arthur,Arel.json(@name,@name)))