In addition to the making all the tests pass, this series of patches:
Contain patches for other platforms (e.g. sqlite), and
Introduces flakiness for the to_sql tests.
Point (1.) is a side effect of rails 7 libraries. Point (2.) is the result of making the test work: the helper introduced in commit cc6fedff, and called in 5d5ea3d, 24020f51, e7240642, etc. replaces the way introspection to get columns and their types used to be done.
Indeed, we now rely on the schema_cache stored in the DB connection itself to get column-level, db, information.
A possible fix for to_sql is creating a (or using a pre-existing) Mock ActiveRecord Adapter, and replace the current method used in the test.
Contains fixes to the MS SQL Server test suite.
In addition to the making all the tests pass, this series of patches:
sqlite
), andto_sql
tests.Point (1.) is a side effect of rails 7 libraries. Point (2.) is the result of making the test work: the helper introduced in commit cc6fedff, and called in 5d5ea3d, 24020f51, e7240642, etc. replaces the way introspection to get columns and their types used to be done.
Indeed, we now rely on the
schema_cache
stored in the DB connection itself to get column-level, db, information.A possible fix for
to_sql
is creating a (or using a pre-existing) Mock ActiveRecord Adapter, and replace the current method used in the test.