search

Faveod / arel-extensions

Extending Arel
MIT License
142 stars 24 forks source link

Format date w/ lang #68

Closed stackmystack closed 2 years ago

stackmystack commented 2 years ago

This whole PR should be discarded. There's no way we can guarantee consistent formatting by locale across different RDBMSes.

akimd commented 2 years ago

This whole PR should be discarded. There's no way we can guarantee consistent formatting by locale across different RDBMSes.

Really? I don't see a problem with at least the first commits. You are "only" saying that we can't expect a single answer, but that's no reason, IMHO, to not support the formatting directives. We just don't guarantee the result, but that's best effort. The tests must be more tolerant I guess.