search

Faveod / arel-extensions

Extending Arel
MIT License
143 stars 24 forks source link

CI Fixes for MSSQL and PostgeSQL #82

Closed stackmystack closed 2 years ago

stackmystack commented 2 years ago

In this PR we:

  1. Add support for SQL Server 2017 and 2019 in github actions
  2. Return AppVeyor support to test with SQL Server editions < 2017
  3. Fix issues with Postgres multilingual support in test environment.
  4. Fix various tests for sqlite.
stackmystack commented 2 years ago

So what's the final result in terms of success? Some failing tests now pass?

We still have failing tests, notably:

  1. to_sql and that's the most urgent to address
  2. mssql for SQL Server < 2017. It's mainly a problem with TRIM. All tests pass for SQL Server >= 2017, and if we revert it to the previous definition (which uses LTRIM + RTRIM), we have failures in all versions.
  3. mssql for Rails >= 7. I already submitted an issue to the devs of activerecord-sqlserver-adapter.