Faxundo
commented
3 months ago About the first thing, i dont not sure what you refeer. When you use Flutter Echo for break a mineral ore and a echo is created, then you pick the mineral of the echo but too pick the ore through Silk touch, right? If so, yes, is a exploit of infinite minerals. I check it for the next versions. Maybe make that flutter echo effect not works with silk touch.
The second, yes, i only works what vanilla and still don't work with support for others mods. For identify if the block is a ore or not i generate a "Ore" tag and add the ores manually with datagen. For solve this i need investigate, maybe need other solution for identify ore blocks. I not sure.
Yes, the Flutter Echo Awake should be break more what ore block with it special ability. The second pasive ability give a extra attack, so can be useful for the combat. And in minecraft, the "Mine" not is only ores or undercave, can mine entire world. Definitley is a multi-tool. In general i try that old legend items can be used in different occasions.
BioMasterZap
I noticed some potentially unintended behavior with Fluttering Echo while testing mineshaft mods last night. This is for Old Legends v4.0.0 in Fabric 1.20.4.
If enchanted with Silk Touch, Fluttering Echo can be used to duplicate ores. For example, if I have 5 Diamond Ore and mine it with a Silk Touch Fluttering Echo, I'd still retain the 5 Diamond Ore while having the base 30% chance to generate echo ores for diamonds; the ores could be replaced, mined with silk touch for echo diamonds, and repeated indefinitely for infinite diamonds (or most other resources). For now, I am just turning the echo chance way down to 1% normal and 5% awake so the exploit would be considerably slower and less worthwhile, but it might be worth preventing Echoes if Silk Touch is used; it could even be a config option.
The other issue I noticed is that the Echoes do not seem to work with any modded ores. When mining new modded ores like Sulphur and Tungsten, Fluttering Echo did not generate Echoes. When mining modded variants of vanilla ores from Excavated Variants (e.g. Sandstone Copper Ore), it would generate an Echo but the Echo would have no drops. These ores all still work normally with intended ore drops when mined with Fluttering Echo; it is only the Echoes that have issue. Not sure exactly why it isn't working on these modded ores, especially the variant behavior, but it would be nice if there were some way to add support, even if through configs or data packs.
Also, I am not sure if this is intended, but Fluttering Echo seems to be a multi-tool. It appears to break axe blocks like wood and shovel blocks like dirt effectively instead of just pickaxe blocks like stone. Personally, I think it is kind of a neat feature for a rare/special tool to have, but it surprised me sine I didn't see it mentioned on the mod page or wiki.